Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

pass data to afterhooks, too #386

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

ktmud commented Mar 2, 2014

see #385

Owner

1602 commented Mar 2, 2014

It only makes sense for validations before saving (such as afterValidate), but for all other it will be misleading. Could you please take that into account?

Contributor

ktmud commented Mar 2, 2014

For afterSave, people can receive data for some kind of double check (though they may never need it). Setting up a new limitation doesn't bring much good, meanwhile introduced more complexity, and broke the consistency.

BTW, is it possible to rewrite the hook mechanism with hooks-js or something? Currently, adding multiple handler on one hook is painful.

Owner

1602 commented Mar 2, 2014

Let's leave standardization with breaking changes to major release. This argument was introduced after hooks was implemented, to get proof of traction before making any breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment