Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Color constructors taking integer arguments (fixes #123) #124

Merged
merged 2 commits into from May 11, 2019

Conversation

@aaneto
Copy link
Contributor

aaneto commented May 11, 2019

Fixes #123.

Adds two constructors:

  • rgba8
  • rgba

Both equal to their floating point counterparts but taking u8 integers as arguments. Feel free to point out any issue.


This change is Reviewable

@17cupsofcoffee 17cupsofcoffee merged commit ab210a4 into 17cupsofcoffee:master May 11, 2019
5 of 6 checks passed
5 of 6 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@17cupsofcoffee

This comment has been minimized.

Copy link
Owner

17cupsofcoffee commented May 11, 2019

The CI build failed, but I'm pretty sure that's due to an unrelated issue (a dependency has bumped their minimum supported Rust version in a patch release by the looks of it 😠), so I've merged your PR. Thanks for saving me some work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.