New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers on tables are too big #1202

Closed
hbillings opened this Issue Jan 5, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@hbillings
Member

hbillings commented Jan 5, 2017

They run into each other, force the widths of the content cells to be too great in some cases (especially numerals) and are generally a pain. They're our default 16px currently. @ericronne, what do you think?
screen shot 2017-01-04 at 5 44 12 pm

@ericronne

This comment has been minimized.

Contributor

ericronne commented Jan 5, 2017

16 is pretty big for tabular data. Drop to 14?
There should be a variable for that: $medium-font-size

Also some alignment issues going on (yrs of experience, price). LMK if you need help, thx!

@hbillings

This comment has been minimized.

Member

hbillings commented Jan 6, 2017

@ericronne Here's what 14 looks like:
screen shot 2017-01-06 at 1 24 12 pm

Tell me more about the alignment?

@ericronne

This comment has been minimized.

Contributor

ericronne commented Jan 13, 2017

Some of the alignment funkiness is discussed in [this slack thread] (https://gsa-tts.slack.com/archives/calc/p1484258246000547).

The biggest problem i see is with minimum years of experience. In the layout above, eg, my brain merges two columns together. I see, "5 Hour."

Here's one way things could be arranged...
x

And there's @jseppi's space-saving thought (#1240), which we can chat on, too

@jseppi

This comment has been minimized.

Contributor

jseppi commented Jan 25, 2017

Will be closed by #1245

@jseppi

This comment has been minimized.

Contributor

jseppi commented Jan 26, 2017

all fixed, @hbillings?

@hbillings

This comment has been minimized.

Member

hbillings commented Jan 27, 2017

Done in #1285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment