New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change title of data explorer page to be name of search #1315

Closed
toolness opened this Issue Feb 3, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@toolness
Contributor

toolness commented Feb 3, 2017

@tram just had a great suggestion: since it's likely that COs have multiple CALC tabs open to different searches, what if we change the title of the page (i.e., the tab in their browser) from CALC / Home to [labor category name] - CALC search? That way the CO would then have a bunch of differentiated tabs rather than identical ones.

(Just tried out Google and this is what they do. Noice.)

@tram

This comment has been minimized.

Member

tram commented Feb 3, 2017

Sweet! I like the Google Search approach you mentioned Atul of "[search query] - Google Search", so maybe something like "[search query] - CALC results"? @jeremyzilar, whadya think?

@jseppi

This comment has been minimized.

Contributor

jseppi commented Feb 14, 2017

Referencing back to #1372 since, depending on the clarification for how to "fix" that issue, we might not want to show the query in the title of the page either.

@toolness

This comment has been minimized.

Contributor

toolness commented Feb 14, 2017

I dunno, dude. Unless the security folks really think that Google has the same problem, it seems like an ok thing to do.

@jseppi

This comment has been minimized.

Contributor

jseppi commented Feb 21, 2017

The fix to #1372 was to simply add some max length validation, so I think it's safe to implement the suggestion here.

@jseppi

This comment has been minimized.

Contributor

jseppi commented Feb 21, 2017

I used this in a previous project: https://github.com/nfl/react-helmet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment