New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S70 parser doesn't always stop at the end of the pricing table #1318

Closed
jseppi opened this Issue Feb 3, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@jseppi
Contributor

jseppi commented Feb 3, 2017

@jseppi

This comment has been minimized.

Contributor

jseppi commented Feb 3, 2017

Ok, so currently we keep attempting to parse rows until we get to a row with no sin AND no price_including_iff. I think in all our examples, the proposed price table had at least one blank line between it and the start of the "Most Favored Customer's Discount..." bunch of cells, so our approach worked. Obviously in practice, that blank line does not exist so we need to be better at predicting when we've reached the end of the price table.

@jseppi

This comment has been minimized.

Contributor

jseppi commented Feb 3, 2017

We could also check for the the first cell in the row for the start of that "Most Favored Customer's Discount" text as an additional stop check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment