New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data "tutorial" #1460

Merged
merged 32 commits into from Sep 21, 2018

Conversation

Projects
None yet
5 participants
@ericronne
Contributor

ericronne commented Mar 2, 2017

Closes #2148

@ericronne ericronne changed the title from [WIP} Add data "tutorial" to [WIP] Add data "tutorial" Mar 2, 2017

@ericronne

This comment has been minimized.

Contributor

ericronne commented Mar 2, 2017

Pairing with @toolness on this in coworking today.

toolness and others added some commits Mar 2, 2017

@ericronne

This comment has been minimized.

Contributor

ericronne commented Mar 3, 2017

Spotted some copy issues; i'll fix.

Copy edits, card chunking
Rewrote some text so the instructions are more accurate to the
experience for those viewing this page, and so that it reflects the new
motif where “Add price data” is always visible. Also broke up the
content into individual cards.
@ericronne

This comment has been minimized.

Contributor

ericronne commented Mar 3, 2017

Need help to complete this stuff:

  • Remove padding from above the H3 elements, all of which are the first items on cards (and therefore are double padded)
  • Apply css properly (looks like we have some explicit style specs in tutorial.html, e.g.
  • Double check the overall code
  • Add alt tags and give the work an accessibility onceover
  • Make images responsive!

ericronne added some commits Mar 3, 2017

Adds exception for <h3> when used as a card header
This should fix the issue of extraneous top margin on the tute cards.
NOTE: an exception already existed for <h2>s applied in that way (on `
_page.scss ` ). I simply duped that code. I couldn’t get it to work by
merely adding ` h3:first-child ` to that string. I likely just don’t
know the syntax!
@ericronne

This comment has been minimized.

Contributor

ericronne commented Apr 6, 2018

Note: with this addition, the "Add price data" tab would always be visible, regardless of whether a user is logged in or not:
image

When not signed in, those clicking the tab would be taken to the tutorial page. This way, everyone can learn about CALC's neat crowd-sourcing tool. Those who haven't been granted access may wonder why, and/or how they can get it. The design doesn't currently address that situation, but it may not need to yet.

ericronne added some commits Apr 9, 2018

@ericronne

This comment has been minimized.

Contributor

ericronne commented Apr 10, 2018

@hbillings (or @jseppi), the embedded s70 example now spills over the edges. My wild guess is that this is because of render order: the browser doesn't know what size the card is at the time it renders the example spreadsheet row.

Regardless: Help wanted :)

image

Adds "Add price data" tab to non-logged-in site
... which links to the tutorial
@@ -6,6 +6,8 @@
{% endif %}
{% if perms.data_capture.add_submittedpricelist %}
<li{% if current_selected_tab == 'upload_price_data'%} class="selected"{% endif %}><a href="{% url 'data_capture:step_1' %}">Add price data</a></li>
{% else %}
<li{% if current_selected_tab == 'upload_price_data'%} class="selected"{% endif %}><a href="{% url 'data_capture:tutorial' %}">Add price data</a></li>

This comment has been minimized.

@jseppi

jseppi Apr 10, 2018

Contributor

😮

This comment has been minimized.

@ericronne

ericronne Apr 10, 2018

Contributor

Good 😮 or bad 😮?
I'm just rollin' the 🎲 🎲 … papa needs a new pair of 👞👞!

This comment has been minimized.

@jseppi

jseppi Apr 10, 2018

Contributor

Ha, I don't know. My opinion is that this will be not useful, and maybe confusing, to the vast majority of CALC users. We only have <20 people doing price list uploads, and thousands (?) who visit the site, most of whom will not be getting any kind of add-data functionality.

It seems like the purpose of adding this link is to inform users that the data in CALC are manually captured/sourced. Maybe there's a more direct way to do that than to add a front-and-center nav that will likely never be useful to most users.

ericronne and others added some commits Sep 20, 2018

@ericronne ericronne changed the title from [WIP] Add data "tutorial" to Add data "tutorial" Sep 21, 2018

@ericronne ericronne requested a review from hbillings Sep 21, 2018

@ericronne

This comment has been minimized.

Contributor

ericronne commented Sep 21, 2018

@hbillings i highly doubt this meets accessibility guidelines, but otherwise ... g2g?

@hbillings

This comment has been minimized.

Member

hbillings commented Sep 21, 2018

@ericronne Can you say more about your accessibility concerns?

@ericronne

This comment has been minimized.

Contributor

ericronne commented Sep 21, 2018

Not sure whether the images need alt tags eg

@hbillings

This comment has been minimized.

Member

hbillings commented Sep 21, 2018

Ah yeah -- either we should fill those out or they should have empty alt tags. I'll take a crack at filling them out in a way that makes sense?

Do we want to also add a link to this tutorial to the data capture Step 1 page?

@ericronne

This comment has been minimized.

Contributor

ericronne commented Sep 21, 2018

thx! and yep it's there!
image

@hbillings

🎉

<div class="card">
<div class="content">
<h3>Then, upload your price list</h3>
<p>Once you're logged in and viewing page one of the "Add price data," you can upload your approved price list. You will be asked for very basic details around the contract (e.g. contract number, schedule name, business size, etc.). When you have filled that out, simply upload your contract to CALC.</p>

This comment has been minimized.

@hbillings

hbillings Sep 21, 2018

Member

extraneous "the"?

This comment has been minimized.

@ericronne

ericronne Sep 21, 2018

Contributor

👍

@ericronne ericronne merged commit 447659f into develop Sep 21, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
security/snyk - package.json (CALC) No manifest changes detected
security/snyk - requirements.txt (CALC) No manifest changes detected

@ericronne ericronne deleted the add-data-how-to branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment