New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging #1569

Merged
merged 9 commits into from Sep 19, 2017

Conversation

Projects
None yet
2 participants
@jseppi
Contributor

jseppi commented Sep 18, 2017

To Do:

  • upgrade cg-django-uaa once 18F/cg-django-uaa#39 is resolved. This should get us logging of successful and unsuccessful logon events.
  • add log handling for 'uaa_client'
  • add uaa_client.middleware.UaaRefreshMiddleware, as this is needed to upgrade from cg-django-uaa 0.0.1 to 1.0.0.
  • make sure we have logging for all this stuff:
    • successful and unsuccessful account logon events (done by cg-django-uaa),
    • account management events,
    • object access - just http logs should suffice
    • policy change - unsure what this is,
    • privilege functions,
    • process tracking - unsure what this is,
    • system events - we have logging when bulk uploads happen, and there are lots of other system events that are logged automatically by cloud.gov,
    • all administrator activity
      • Price list with id FOO has been set to STATUS by user BAR is logged when price list status changes are made.
    • authentication checks,
    • authorization checks
      • add logging in staff_login_required decorator
    • data deletions,
    • data access,
    • data changes, and
    • permission changes
James Seppi
start adding additional logging
- add logging in staff_login_required decorator
- add log handling for uaa_client
James Seppi

@jseppi jseppi changed the title from [WIP] Add additional logging to Add additional logging Sep 19, 2017

@jseppi jseppi requested a review from toolness Sep 19, 2017

@jseppi

Since both @toolness and I worked on this, I am also submitting this review as my approval of the code he contributed.

logging system."""
if instance.action_flag == ADDITION:
logger.info("%s created %s '%s'", instance.user.username,

This comment has been minimized.

@jseppi

jseppi Sep 19, 2017

Contributor

f-strings would be nice here and throughout this file, but not necessary

This comment has been minimized.

@toolness

toolness Sep 19, 2017

Contributor

yeah i was just copypasta'ing from the ol' eregs.

@toolness

ULTRA COOL

@jseppi jseppi merged commit 97fc9de into develop Sep 19, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 96% (0.0% change)
Details

@jseppi jseppi deleted the additional-logging branch Sep 19, 2017

jseppi pushed a commit that referenced this pull request Sep 20, 2017

James Seppi
Merge tag 'v2.8.0' into develop
Release 2.8.0

/// Added

- Added additional required logging (#1569).

@ctro ctro referenced this pull request Oct 26, 2017

Closed

Add additional logging for ATO #1655

12 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment