New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pricelist status logging and add tests #1579

Merged
merged 1 commit into from Sep 20, 2017

Conversation

Projects
None yet
2 participants
@jseppi
Contributor

jseppi commented Sep 20, 2017

  • fix #1578
  • show status text instead of code
  • add tests to check that logging is happening when pl status changes
James Seppi
improve pricelist status logging and add tests
- fix #1578
- show status text instead of code
- add tests to check that logging is happening when pl status changes

@jseppi jseppi self-assigned this Sep 20, 2017

@jseppi jseppi requested a review from toolness Sep 20, 2017

@toolness

NOICE

@jseppi

This comment has been minimized.

Contributor

jseppi commented Sep 20, 2017

Will merge into develop but won't be able to promote this (or other code) up to production until after the current pentest is finished.

@jseppi jseppi merged commit e75c282 into develop Sep 20, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 96% (0.0% change)
Details

@jseppi jseppi deleted the 1578-improve-pl-status-logging branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment