New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine jest and python coverage reporting #1653

Merged
merged 2 commits into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@jseppi
Contributor

jseppi commented Mar 22, 2018

This PR adds combined test coverage reporting of our Jest tests (for the Data Explorer React code) with our py.test tests.

  • upgrade jest version
    • also update all component snapshots since they render slightly differently (basically just formatting) with this new version
  • add coverage/ to ignore-dotfiles
  • add jest config to package.json

Closes #1439

James Seppi
combine jest and python coverage reporting
- upgrade jest and snapshots
- add coverage/ to ignore-dotfiles
- add jest config to package.json

@jseppi jseppi self-assigned this Mar 22, 2018

@jseppi

This comment has been minimized.

Contributor

jseppi commented Mar 22, 2018

You can see the new covered files over at https://codeclimate.com/github/18F/calc/compare/9ae621ec71992aef877e3cb3a1b275701321c99b...16e4dc377e769dcbc94d2f3119ad592078908d65#ratings

Note that our overall coverage decreased by 5.5% (hence the failing status check in this PR), but there was no change in actual coverage, just in reported coverage since we're now including the jest coverage report. Thus, I think this is still good to merge pending review.

@jseppi jseppi changed the title from [WIP] combine jest and python coverage reporting to Combine jest and python coverage reporting Mar 22, 2018

@jseppi jseppi requested a review from toolness Mar 22, 2018

@toolness

Cool, this looks good to me, thanks sir!

exports[`<BusinessSize> matches snapshot 1`] = `
<div
className="filter filter-business_size">
className="filter filter-business_size"
>

This comment has been minimized.

@toolness

toolness Mar 22, 2018

Contributor

Oh weird, is the reason for this just b/c of the Jest upgrade? I guess it's probably doing this so future diffs based on attribute changes are easier to read, huh...

This comment has been minimized.

@jseppi

jseppi Mar 22, 2018

Contributor

Yep, believe so

@jseppi jseppi merged commit 3224ff2 into develop Mar 22, 2018

2 of 3 checks passed

codeclimate/total-coverage 90% (-5.5% change)
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@jseppi jseppi deleted the 1439-report-jest-coverage branch Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment