New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CircleCI workflows and nightly production tests #1654

Merged
merged 3 commits into from Mar 23, 2018

Conversation

Projects
None yet
2 participants
@jseppi
Contributor

jseppi commented Mar 22, 2018

This PR modifies our CircleCI config to add a workflow for running our production tests (which test various things at the production calc.gsa.gov URL) every night at 2:11AM UTC (10:11 PM ET).

closes #1565

Before merging, we should modify our GitHub branch config to remove the required ci/circleci check and replace it with a required ci/circleci: build check. This change is because now our main CircleCI "job" has a name due to changing to using CircleCI "workflows" (which is necessary for setting up scheduled builds). The old ci/circleci check will be gone so it appears like it is still waiting.

@jseppi jseppi self-assigned this Mar 22, 2018

@jseppi jseppi force-pushed the 1565-nightly-prod-tests branch 5 times, most recently from 494de17 to da00950 Mar 22, 2018

@jseppi jseppi force-pushed the 1565-nightly-prod-tests branch 2 times, most recently from c03119c to 8cb5c94 Mar 22, 2018

James Seppi

@jseppi jseppi force-pushed the 1565-nightly-prod-tests branch from 8cb5c94 to 6eeacf9 Mar 22, 2018

@jseppi jseppi changed the title from [WIP] Setup CircleCI workflows and nightly production tests to Setup CircleCI workflows and nightly production tests Mar 22, 2018

@jseppi jseppi requested a review from toolness Mar 22, 2018

@jseppi

This comment has been minimized.

Contributor

jseppi commented Mar 22, 2018

I did test the scheduled job by doing a commit (that I later rebased away) that had the cron time specified to a minute after the push, and it worked! Note the / nightly workflow success in the screenshot below:

screen shot 2018-03-22 at 3 48 33 pm

@toolness

Nice! This is really helpful, thanks sir. Also good for me to finally have a reference example of how to do these cron jobbies on Circle.

triggers:
- schedule:
# every night at 2:11 AM UTC (10:11 PM ET)
cron: "11 02 * * *"

This comment has been minimized.

@toolness

toolness Mar 22, 2018

Contributor

Thanks for adding the comment here, b/c cron syntax is so friggin' obtuse to me.

@jseppi jseppi merged commit 7a6030e into develop Mar 23, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 90% (0.0% change)
Details

@jseppi jseppi deleted the 1565-nightly-prod-tests branch Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment