New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React to 15.5 and use prop-types #1680

Merged
merged 3 commits into from Mar 28, 2018

Conversation

Projects
None yet
2 participants
@jseppi
Contributor

jseppi commented Mar 28, 2018

This updates our React (and associated packages) to v15.5, and migrates us to the prop-types package (instead of using React.PropTypes, which is deprecated). I used react-codemod's https://github.com/reactjs/react-codemod#react-proptypes-to-prop-types transform to automatically update our code.

I think we should probably upgrade to React v16, but wanted to take a shorter step up first before tackling that.

James Seppi added some commits Mar 28, 2018

James Seppi
use prop-types instead of React.PropTypes
React.PropTypes is deprecated in favor of the standalone prop-types package.
I used react-codemode's https://github.com/reactjs/react-codemod#react-proptypes-to-prop-types transform to automatically update our code.

@jseppi jseppi force-pushed the update-react branch from 3f44296 to 57245e4 Mar 28, 2018

@jseppi jseppi changed the title from Update react to 15.5 and use prop-types to Update React to 15.5 and use prop-types Mar 28, 2018

@jseppi jseppi requested a review from toolness Mar 28, 2018

@jseppi jseppi self-assigned this Mar 28, 2018

@toolness

Noice, this seems smart.

@jseppi jseppi merged commit 5103e99 into develop Mar 28, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate Approved by James Seppi.
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@jseppi jseppi deleted the update-react branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment