Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade React to v16 #1685
This upgrades the Data Explorer app to the latest version of React,
As part of this upgrade, I also had to upgrade a number of other dependencies:
and make a few small changes to how
Overall the upgrade was fairly painless. All tests are passing, and I don't notice any differences when manually playing around with the Data Explorer interface, but please do some local exercise during your review, @toolness.
Nice! This looks fab. I played around with it on my machine and it works nicely too.
Just a few notes regarding the release notes:
requestAnimationFrame. I forget what version of IE we support at this point, but we should either make sure we still support that version, or make sure it's OK to drop support for it...
The release notes also mention:
It is not safe to re-render into a container that was modified by something other than React. This worked previously in some cases but was never supported. We now emit a warning in this case. Instead you should clean up your component trees using
I think we should be OK but IIRC, we do allow some legacy jQuery plugins to futz around with DOM nodes that we've created via React. I don't think they fall into this use case, but just in case we notice any funny business, I guess we should consider using
@toolness: good point about the various polyfills.
I do think we should re-evaulate our polyfill strategy to be a little smarter about when/what we include. Right now, we always include our polyfills in our bundle. We could, for instance, only include