New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break non-watched builds on sass error; upgrade gulp-sass #1785

Merged
merged 2 commits into from Apr 17, 2018

Conversation

Projects
None yet
2 participants
@jseppi
Contributor

jseppi commented Apr 17, 2018

ref #1777

Adds a stream 'error' event handler to the sass task that will cause the build to exit with a non-zero status code when a sass error occurs during a non-watched build.

This is nice for CI because builds will fail faster and the cause of the failure will be more easily visible in the CircleCI logs.

@jseppi jseppi self-assigned this Apr 17, 2018

@jseppi jseppi requested a review from toolness Apr 17, 2018

@toolness

To clarify, isProd will be true on any CircleCI build, right? Not just CALC's production instance?

@jseppi

This comment has been minimized.

Contributor

jseppi commented Apr 17, 2018

@toolness: oh, good catch. Actually it won't be until the deployment step, but we should break the build before that. What do you think about instead checking process.env.CI?

@jseppi

This comment has been minimized.

Contributor

jseppi commented Apr 17, 2018

I totally forgot we also have an isWatching var. That might be the best thing to use. Will change to that.

@toolness

This comment has been minimized.

Contributor

toolness commented Apr 17, 2018

Ooo ya I like using isWatching!

@jseppi jseppi force-pushed the 1777-break-gulp-on-sass-err branch from 4a056d8 to ae1d90c Apr 17, 2018

@jseppi jseppi force-pushed the 1777-break-gulp-on-sass-err branch from ae1d90c to 825e778 Apr 17, 2018

@jseppi jseppi changed the title from break prod builds on sass error; upgrade gulp-sass to break non-watched builds on sass error; upgrade gulp-sass Apr 17, 2018

@jseppi jseppi merged commit 6214242 into develop Apr 17, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@jseppi jseppi deleted the 1777-break-gulp-on-sass-err branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment