New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to dockerized project setup #1793

Merged
merged 4 commits into from Apr 18, 2018

Conversation

Projects
None yet
2 participants
@jseppi
Contributor

jseppi commented Apr 17, 2018

Closes #1743.

This modifies all our developer documentation to assume that Docker/Docker Compose are used for running a CALC development environment.

@jseppi jseppi self-assigned this Apr 17, 2018

@jseppi jseppi requested a review from toolness Apr 17, 2018

@jseppi jseppi changed the title from [WIP] Default to dockerized project setup to Default to dockerized project setup Apr 17, 2018

@jseppi jseppi force-pushed the 1743-docker-setup branch from f154be5 to 89e3bfe Apr 17, 2018

@jseppi jseppi force-pushed the 1743-docker-setup branch from 4a76f0e to f7c2a4e Apr 17, 2018

James Seppi

@jseppi jseppi force-pushed the 1743-docker-setup branch from f7c2a4e to 54e2f77 Apr 17, 2018

@toolness

With the exception of the broken guide link, I think this is nice. Thanks!

[Django]: https://www.djangoproject.com/
[18F Docker guide]: https://pages.18f.gov/dev-environment-standardization/virtualization/docker/

This comment has been minimized.

@toolness

toolness Apr 18, 2018

Contributor

Blerarg, this 404's now. I think CM wrote a new guide at some point but I'm not sure where it is...

This comment has been minimized.

@jseppi

jseppi Apr 18, 2018

Contributor

Good catch. I’ll track it down or remove the reference.

James Seppi

@jseppi jseppi merged commit 50c60bc into develop Apr 18, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@jseppi jseppi deleted the 1743-docker-setup branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment