New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin user search #1794

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@toolness
Contributor

toolness commented Apr 17, 2018

Fixes #1726.

It took me a really long time to figure out what was wrong. At first I started comparing our search_form.html to Django 1.11's and didn't notice anything different. Then I started fiddling with our custom UserAdmin subclass, to no avail. Then I just started deleting stuff, slowly reverting our custom Django admin back to the default one.

The user search field started working again when I deleted search_form.html, which made Django fall back to the default one. Which was weird, because that was the first thing that I'd looked at. But it wasn't until I looked really closely that I noticed that our search field had two name attributes! Oof.

@toolness toolness requested review from hbillings and jseppi Apr 17, 2018

@jseppi

This comment has been minimized.

Contributor

jseppi commented Apr 17, 2018

whoa!

@jseppi

jseppi approved these changes Apr 17, 2018

Thanks for the the digging!

@hbillings

This comment has been minimized.

Member

hbillings commented Apr 17, 2018

wat

@toolness toolness merged commit d27a080 into develop Apr 17, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@toolness toolness deleted the fix-user-search branch Apr 17, 2018

@toolness

This comment has been minimized.

Contributor

toolness commented Apr 17, 2018

haha woot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment