New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog - link GitHub issues and PRs to CALC repo #1816

Merged
merged 3 commits into from Apr 20, 2018

Conversation

Projects
None yet
2 participants
@jseppi
Contributor

jseppi commented Apr 20, 2018

Closes #1296

Uses a regex to find and replace all GitHub-like issue/PR links (eg #123) with a Markdown link to the issues/PRs in the CALC repo.

@jseppi jseppi self-assigned this Apr 20, 2018

@jseppi jseppi requested a review from toolness Apr 20, 2018

James Seppi

@jseppi jseppi force-pushed the 1296-gh-links branch from 90faa44 to e71a3bf Apr 20, 2018

@@ -22,9 +22,13 @@
UNRELEASED_HEADER = '## [Unreleased][unreleased]'
GH_ISSUE_RE = re.compile(r'(?P<issue_link>#(?P<issue_id>\d+))')
GH_ISSUE_LINK = 'https://github.com/18F/calc/issues/'

This comment has been minimized.

@toolness

toolness Apr 20, 2018

Contributor

We've actually got a BASE_GITHUB_URL defined in styleguide\templatetags\styleguide.py... I wonder if it'd be useful to move that into settings.py and then base GH_ISSUE_LINK off it?

This comment has been minimized.

@jseppi

jseppi Apr 20, 2018

Contributor

ah yeah, that'd be good. Will do!

@toolness

Nice, thanks!

@jseppi jseppi force-pushed the 1296-gh-links branch from 0ca32d6 to a63e9fb Apr 20, 2018

@jseppi jseppi merged commit 35b5d5d into develop Apr 20, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@jseppi jseppi deleted the 1296-gh-links branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment