New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include DAP on authenticated pages. #1843

merged 2 commits into from May 3, 2018


None yet
2 participants

toolness commented May 1, 2018

This fixes #903.

Note that it's subtly different from #903, though: it actually disables DAP when users are authenticated at all, because that minimizes damage in case DAP is compromised, and also doesn't negatively impact analytics much because so few people actually log in to CALC.

@toolness toolness requested a review from hbillings May 1, 2018

@toolness toolness merged commit 4dc4642 into develop May 3, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
codeclimate All good!
codeclimate/total-coverage 92% (0.0% change)

@toolness toolness deleted the 903-no-authenticated-dap branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment