New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'hourglass' to 'calc' #1845

Merged
merged 2 commits into from May 3, 2018

Conversation

Projects
None yet
2 participants
@toolness
Contributor

toolness commented May 1, 2018

Fixes #93.

Notes:

  • There are still a handful of references to Hourglass in .about.yml, but that is because it's describing history, e.g. mentioning that the project was originally called Hourglass and later renamed to CALC.

  • I added a step to update.sh that clears a bunch of cache directories Python uses, which causes tests to fail when package directories are renamed. For more details, see #1845 (comment).

toolness added some commits May 1, 2018

@toolness toolness requested a review from hbillings May 1, 2018

@@ -2,6 +2,10 @@
set -e
echo "----- Clearing Python cache -----"
# https://stackoverflow.com/a/30659970
find . | grep -E "(__pycache__|\.pyc|\.pyo$)" | xargs rm -rf

This comment has been minimized.

@toolness

toolness May 1, 2018

Contributor

When I renamed hourglass/ to calc/, Python complained about some cached files thinking they were in an hourglass directory when they weren't, which broke tests. This clears Python's cache whenever devs run bash docker-update.sh so that we don't have to deal with that.

This comment has been minimized.

@hbillings

hbillings May 3, 2018

Member

THANK YOU

@@ -59,7 +59,7 @@ links:
text: CALC production instance
- url: https:/calc-dev.apps.cloud.gov/
text: CALC development instance
- url: https://trello.com/b/LjXJaVbZ/hourglass
- url: https://trello.com/b/LjXJaVbZ/calc

This comment has been minimized.

@toolness

toolness May 1, 2018

Contributor

Interestingly, this link actually works!

Although, uh, since we are moving from Trello to github, maybe we should remove this entirely. I guess I will leave that for a separate issue, which I have filed as #1846.

@@ -1,2 +0,0 @@
ALTER USER hourglass CREATEDB;
GRANT ALL ON DATABASE hourglass TO hourglass;

This comment has been minimized.

@hbillings

hbillings May 3, 2018

Member

Just makin' sure that it's okay to totally remove these instead of rename them!

This comment has been minimized.

@toolness

toolness May 3, 2018

Contributor

yep, i checked and it doesn't seem like setup.sql is actually being used by anything!

@hbillings

😎

@toolness toolness merged commit fb81624 into develop May 3, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate 10 fixed issues
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@toolness toolness deleted the 93-bye-hourglass branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment