Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Track virtual pageviews and custom events on DAP #1852
As mentioned in #847 and #940, we currently report custom pageviews and custom events only to 18F Google Analytics, but not DAP. This fixes things so we report them to both. This will hopefully help make it less confusing to figure out which GA account to look at.
A note on eslint
After 2 years of struggling with eslint and just now almost tearing my hair out trying to placate eslint and typescript at the same time, I'm officially declaring that I am tired of eslint and don't think it's really worth our time to appease.
In the spirit of "A foolish consistency is the hobgoblin of little minds", I'm aggressively telling eslint to ignore rules it complains about, but that I think are pointless (or better auto-fixed in the indeterminate future by something like prettier).