Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track virtual pageviews and custom events on DAP #1852

Merged
merged 6 commits into from May 3, 2018

Conversation

Projects
None yet
2 participants
@toolness
Copy link
Contributor

commented May 3, 2018

As mentioned in #847 and #940, we currently report custom pageviews and custom events only to 18F Google Analytics, but not DAP. This fixes things so we report them to both. This will hopefully help make it less confusing to figure out which GA account to look at.

A note on eslint

After 2 years of struggling with eslint and just now almost tearing my hair out trying to placate eslint and typescript at the same time, I'm officially declaring that I am tired of eslint and don't think it's really worth our time to appease.

In the spirit of "A foolish consistency is the hobgoblin of little minds", I'm aggressively telling eslint to ignore rules it complains about, but that I think are pointless (or better auto-fixed in the indeterminate future by something like prettier).

@toolness toolness requested a review from hbillings May 3, 2018

@hbillings
Copy link
Member

left a comment

I love the renaming/refactoring you've done here -- makes it much easier to tell what's being imported and used on any given page!

toolness added some commits May 3, 2018

Merge pull request #1853 from 18F/remove-dap-hacks
Remove dap-hacks.js and auto-track outbound links & downloads ourselves
@toolness

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2018

Woot thanks!!

@toolness toolness merged commit bc77776 into develop May 3, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate 1 fixed issue
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@toolness toolness deleted the dap-virtual-pageviews branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.