New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample users and "switch user" menu #1859

Merged
merged 9 commits into from May 10, 2018

Conversation

Projects
None yet
2 participants
@toolness
Contributor

toolness commented May 7, 2018

This fixes #1842 by adding a "Switch user" menu to the development nav, visible only when DEBUG and SHOW_DEBUG_UI are true (the default on dev instances):

switch-user

The third entry is highlighted because the mouse is hovering over it.

Notes

  • The text of "Style guide" and "Docs" in the developer navigation has changed from white to improve the contrast ratio.

  • I used a <details> element to avoid the need for any JS but I'm now realizing that this might not be semantically accurate. Blarg whatever it's just for devs.

To do

toolness added some commits May 7, 2018

@toolness toolness changed the title from [WIP] Add sample users and "switch user" menu to Add sample users and "switch user" menu May 7, 2018

@toolness toolness requested a review from hbillings May 7, 2018

@hbillings

LGTM!

{% if show_debug_ui %}
|
<details>
<summary>Switch user&hellip;</summary>

This comment has been minimized.

@hbillings

hbillings May 10, 2018

Member

oh, interesting, I haven't seen these really used before!

@@ -22,9 +22,9 @@ Running `docker-compose run app python manage.py initgroups` will initialize or
### Initial user creation
When CALC is run for the first time, there will be no users in its database.
During development, a menu is available at the top of every page which allows you to quickly log in as a variety of example users, each of which represents a different kind of CALC role.

This comment has been minimized.

@hbillings

hbillings May 10, 2018

Member

Do we expand upon what these user roles are somewhere?

This comment has been minimized.

@toolness

toolness May 10, 2018

Contributor

Yup, in the section right above this one :)

hbillings and others added some commits May 10, 2018

@toolness toolness merged commit 55f6264 into develop May 10, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.2% change)
Details

@toolness toolness deleted the sample-users branch May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment