New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint as part of JS compilation #1867

Merged
merged 3 commits into from May 9, 2018

Conversation

Projects
None yet
2 participants
@toolness
Contributor

toolness commented May 8, 2018

In the spirit of aggressively rolling back eslint, this disables eslint when compiling JS, for the reasons outlined in #1511. If folks want to see live eslint feedback during development, it's better for them to use an editor plugin than wait upwards of 10 seconds for gulp to annoy them. Note that ultratest does still run eslint, so it's still part of our test suite.

I believe this also shaves a few seconds off our test suite, because until now we were actually running eslint twice: once during compilation of the JS, and again during a separate linting phase.

@toolness toolness requested a review from hbillings May 8, 2018

@hbillings

YASS

@toolness toolness merged commit 65e6dcb into develop May 9, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@toolness toolness deleted the eslint-super-chill branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment