New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document API 'sort' field better #1893

Merged
merged 2 commits into from May 15, 2018

Conversation

Projects
None yet
2 participants
@toolness
Contributor

toolness commented May 11, 2018

Fixes #1889.

This actually subtly changes behavior, too: previously we were allowing any indexed Contract field to be sorted on, which included weird fields like _normalized_labor_category, but now we're specifically only allowing fields that the API exposes to be sorted on.

This also adds some markdown-y utilities to calc.util (couldn't think of a better place to put them) that I think will be useful in the future.

@hbillings

Ugh, I lost the comments I made on this thanks to my computer dropping my wifi. >_< It looks good!

@toolness

This comment has been minimized.

Contributor

toolness commented May 15, 2018

Booo wifi! Ok thanks!

@toolness toolness merged commit f11d8cc into develop May 15, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@toolness toolness deleted the document-sort-field branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment