New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swaps in hue-based colors for "primary" and "secondary" variables #1947

Merged
merged 12 commits into from May 24, 2018

Conversation

Projects
None yet
2 participants
@ericronne
Contributor

ericronne commented May 22, 2018

No description provided.

@ericronne ericronne changed the title from [WIP] Swaps in "blue" colors for "primary" instances to Swaps in hue-based colors for "primary" and "secondary" variables May 22, 2018

@ericronne ericronne requested a review from hbillings May 22, 2018

@ericronne

This comment has been minimized.

Contributor

ericronne commented May 22, 2018

Dealing with remaining buttons in #1948

@hbillings

This is soooooo much easier to read like this! 🤜 🤛

$color-primary-darker: $color-blue-darker;
$color-blue-darkest: #0c4c6f;
$color-blue-darkest: #0c4c6f; // Primary button hover color

This comment has been minimized.

@hbillings

hbillings May 23, 2018

Member

Might be helpful to have these notes in the styleguide instead of in here?

Also, why intermix blue and primary colors?

This comment has been minimized.

@ericronne

ericronne May 23, 2018

Contributor

Sure, will add notes to style guide #1951

Re intermixing: do we need primary and secondary color variables at all any more?

This comment has been minimized.

@hbillings

hbillings May 23, 2018

Member

Yup, the WDS still expects them, so if we don't define them, it will use its own default colors for them.

This comment has been minimized.

@ericronne

ericronne May 23, 2018

Contributor

Hm if our design doesn't reference the primary/secondary/etc colors, why do we need to have them in the variables? We don't include others, such as $color-secondary-dark etc.

$color-secondary: #ccde61;
$color-primary-alt: $color-secondary;
$color-secondary: $color-green-bright;
$color-primary-alt: $color-green-bright;
// TODO: solve disconnect between ^this^ and other "secondary" colors

This comment has been minimized.

@hbillings

hbillings May 23, 2018

Member

If we can't remember what the disconnect is, let's just nix this comment.

This comment has been minimized.

@ericronne

ericronne May 23, 2018

Contributor

☑️

cursor: pointer;
}
label:hover {
text-decoration: underline;
text-decoration: none;

This comment has been minimized.

@hbillings

hbillings May 23, 2018

Member

good call

ericronne added some commits May 23, 2018

@hbillings

This comment has been minimized.

Member

hbillings commented May 23, 2018

@ericronne

This comment has been minimized.

Contributor

ericronne commented May 23, 2018

Makes sense. Regrouped! Ready to go?

@hbillings

This comment has been minimized.

Member

hbillings commented May 23, 2018

yasssss

@ericronne ericronne merged commit b6d556b into develop May 24, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@ericronne ericronne deleted the 1814-pt2-color-assignments branch May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment