Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Swaps in hue-based colors for "primary" and "secondary" variables #1947
changed the title from
[WIP] Swaps in "blue" colors for "primary" instances
Swaps in hue-based colors for "primary" and "secondary" variables
May 22, 2018
This is soooooo much easier to read like this!
Our design doesn’t, but we’re including the WDS and it still references the primary/secondary options. If either we aren’t overriding the color variable of every WDS component (which we aren’t) or someone pulls in a new WDS element and it references a primary/secondary variable, we’re gonna be stuck with whatever WDS uses as its primary/secondary colors because we’d no longer be overriding them anywhere. If we wanted to be REALLY safe, we’d assign new values for all the existing WDS values, but right now we’re only overriding the most commonly used ones.
May 24, 2018
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.