New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade d3-timer to 1.0.7. #1977

Merged
merged 3 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@toolness
Contributor

toolness commented May 30, 2018

Fixes #1976.

So the problem responsible for #1976 was fixed by d3/d3-timer#23.

A challenge here is that we don't use that package, d3-timer, directly; we use d3-transition, which specifies that it needs d3-timer@1, which I think means "anything that is version 1". Until now it was using 1.0.5, which does not include the aforementioned PR.

This PR is the result of running yarn upgrade d3-timer@1, which changes the version of d3-timer used by d3-transition. Apparently it also adds d3-timer to our package.json too, I guess.

@toolness toolness added this to the Development Sprint 1 milestone May 30, 2018

@toolness toolness requested a review from hbillings May 30, 2018

@hbillings

This is some master sleuthing!! 🏆

@toolness toolness merged commit ef7e37f into develop May 31, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@toolness toolness deleted the upgrade-d3-timer branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment