New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise release documentation #2016

Merged
merged 5 commits into from Jun 19, 2018

Conversation

Projects
None yet
2 participants
@toolness
Contributor

toolness commented Jun 18, 2018

This fixes #2014 and also makes a few additional changes:

  • We now tag the release separately from pushing to production, which reduces the possibility of the tag not being pushed and also explicitly makes clear exactly what the tagging process is doing (i.e., making the tag show up on the release page).

  • We no longer wait for CircleCI before changing version.py. Instead, we only wait for review approval from stakeholders, and wait for CircleCI only after the final commit to change version.py has been made. This results in less waiting around for CircleCI to finish.

So even though the release instructions now include one additional step, the process should actually go faster and be less error prone, I think. We'll probably want to run through a small release after this update just to "manually test" these changes, though.

@toolness toolness requested a review from hbillings Jun 18, 2018

@hbillings

This workflow makes more sense to me. Thanks for updating it!

@toolness toolness merged commit 99165df into develop Jun 19, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 92% (0.0% change)
Details

@toolness toolness deleted the release-docs-fixes branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment