New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results table improvements #2027

Merged
merged 20 commits into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@ericronne
Contributor

ericronne commented Jun 28, 2018

Closes #2024

@ericronne ericronne changed the title from [WIP] results table improvements to [WIP] Results table improvements Jun 29, 2018

ericronne added some commits Jun 29, 2018

Changes row hover to green
The previous color (yellow) is only used for warnings. The green has better brand connection.
@ericronne

This comment has been minimized.

Contributor

ericronne commented Jul 2, 2018

Also closes #1780

ericronne added some commits Jul 3, 2018

@ericronne ericronne changed the title from [WIP] Results table improvements to Results table improvements Jul 3, 2018

@ericronne ericronne requested a review from hbillings Jul 3, 2018

ericronne added some commits Jul 3, 2018

@@ -114,7 +118,7 @@ table {
th:first-child,
th:last-child {
position: relative;
padding: $space-2x $space-1x;
padding-left: $space-2x $space-1x;

This comment has been minimized.

@hbillings

hbillings Jul 3, 2018

Member

This isn't valid -- the pattern attribute: thing1 thing2 means "set the top and bottom to thing1 and the left and right to thing2." (Likewise, attribute: thing1 thing2 thing3 thing4 sets each thing clockwise starting from the top.) Either you want to set padding-left to something specific, or you want to change the padding overall.

<path d="M2.8501,6.8497 L7.3501,6.8497" id="Stroke-2" stroke="#0770B5" stroke-width="1" stroke-linecap="round" stroke-linejoin="round"></path>
<path d="M2.8501,4.8497 L4.2671,4.8497" id="Stroke-3" stroke="#0770B5" stroke-width="1" stroke-linecap="round" stroke-linejoin="round"></path>
<path d="M9.4492,0 L6.0752,0 C5.4062,0 5.0712,0.809 5.5442,1.281 L6.1702,1.907 L5.3672,2.711 C5.0482,3.03 5.0482,3.548 5.3672,3.867 L6.3322,4.832 C6.6512,5.151 7.1692,5.151 7.4882,4.832 L8.2912,4.028 L8.9182,4.655 C9.3912,5.129 10.2002,4.794 10.2002,4.125 L10.2002,0.751 C10.2002,0.336 9.8642,0 9.4492,0" id="Fill-4" fill="#0770B5" fill-rule="evenodd"></path>
<path d="M9,5.6553 L9,9.6833 C9,10.4093 8.41,11.0003 7.684,11.0003 L2.517,11.0003 C1.791,11.0003 1.2,10.4093 1.2,9.6833 L1.2,2.5153 C1.2,1.7903 1.791,1.1993 2.517,1.1993 L4.544,1.1993 L4.544,0.0003 L2.517,0.0003 C1.129,0.0003 0,1.1283 0,2.5153 L0,9.6833 C0,11.0713 1.129,12.1993 2.517,12.1993 L7.684,12.1993 C9.071,12.1993 10.2,11.0713 10.2,9.6833 L10.2,5.6553 L9,5.6553 Z" id="Fill-7" fill="#0770B5" fill-rule="evenodd"></path>

This comment has been minimized.

@hbillings

hbillings Jul 3, 2018

Member

I think once we make these React-friendly (by removing the hyphens and camelCasing things like stroke-width), we'll be good to go!

ericronne added some commits Jul 3, 2018

ericronne added some commits Jul 3, 2018

@ericronne ericronne merged commit e64d126 into develop Jul 3, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
security/snyk - package.json (CALC) No manifest changes detected
security/snyk - requirements.txt (CALC) No manifest changes detected

@ericronne ericronne deleted the 2024-results-table-improvements branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment