New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2032: Updated gulp to hopefully make snyk happier #2044

Merged
merged 12 commits into from Jul 18, 2018

Conversation

Projects
None yet
2 participants
@tbaxter-18f
Member

tbaxter-18f commented Jul 11, 2018

Should resolve the minmatch and lodash issues here: https://snyk.io/org/calc/project/fcdd61ae-d494-42e9-9ffc-0d5feb8c33e1

tbaxter-18f added some commits Jul 11, 2018

@hbillings

This comment has been minimized.

Member

hbillings commented Jul 12, 2018

Two suggestions from @cmc333333, in case it's helpful:

  1. try re-running with ssh so you can poke around the file system
  2. when you build locally, maybe try removing the built dir first? could be that a previous run output the files and those are the ones being used now

I'm not sure what I'd be poking around for in SSH, but it does sort of make sense that it's not blowing up locally because the built files already exist.

@tbaxter-18f

This comment has been minimized.

Member

tbaxter-18f commented Jul 16, 2018

Not sure why Github is lagging, but here's the Circle build: https://circleci.com/gh/18F/calc/1368

@hbillings

Excellent work, sir!

tbaxter-18f added some commits Jul 18, 2018

@tbaxter-18f tbaxter-18f merged commit 0dd1bd5 into develop Jul 18, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
security/snyk - package.json (CALC) No new issues
Details
security/snyk - requirements.txt (CALC) No manifest changes detected

@tbaxter-18f tbaxter-18f deleted the 2032-minimatch-update branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment