New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exact match checkbox #2108

Merged
merged 14 commits into from Sep 4, 2018

Conversation

Projects
None yet
3 participants
@hbillings
Member

hbillings commented Aug 29, 2018

Closes #2058.

Since we already removed the "match phrase" option and "match all" is the default, this just simplifies the options further. Required adding a bit of logic to setQueryType to return match_all by default and match_exact on toggle.

screen shot 2018-08-29 at 8 58 55 am

@hbillings hbillings requested review from tadhg-ohiggins and ericronne Aug 29, 2018

hbillings added some commits Aug 29, 2018

@ericronne

Brills!

ericronne added some commits Aug 31, 2018

# the exact match toggle changes value based on querytype,
# but always possesses the name "match_exact"
if _field.get_attribute('value') == value or \
_field.get_attribute('name').find(value):

This comment has been minimized.

@tadhg-ohiggins

tadhg-ohiggins Aug 31, 2018

Collaborator

Fitting really long multiple conditions onto one “line” is a pain in Python…

This comment has been minimized.

@hbillings

hbillings Sep 4, 2018

Member

when the limit is 100 chars but your line is 105 😭

@hbillings hbillings merged commit c5111f6 into develop Sep 4, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
security/snyk - package.json (CALC) No manifest changes detected
security/snyk - requirements.txt (CALC) No manifest changes detected

@hbillings hbillings deleted the 2058-exact-match-checkbox branch Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment