New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the histogram to be the "new" site colors #2143

Merged
merged 17 commits into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@hbillings
Member

hbillings commented Sep 19, 2018

We were still rocking the old histogram under the assumption that we'd merge it when we merged the rest of the data explorer restructure, but we're not going to have time to do the work required for the latter. This updates the visual style of the graph to be consistent with the new styles, since in its current iteration it uses colors no longer used anywhere else on the site.

TODO:

  • Add the dark green line atop the light green bars for 508 compliance.

@hbillings hbillings changed the title from [WIP] Update the histogram to be the "new" site colors to Update the histogram to be the "new" site colors Sep 19, 2018

@hbillings hbillings requested a review from ericronne Sep 19, 2018

@hbillings

This comment has been minimized.

Member

hbillings commented Sep 19, 2018

Looks like:
screen shot 2018-09-19 at 1 55 11 pm

hbillings added some commits Sep 19, 2018

@ericronne

Oh Em Gee i can die happy! Thx!!

@hbillings hbillings merged commit a5638a6 into develop Sep 20, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
security/snyk - package.json (CALC) No manifest changes detected
security/snyk - requirements.txt (CALC) No manifest changes detected

@hbillings hbillings deleted the 2038-green-bars branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment