New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data explorer visuals and grid #2178

Merged
merged 43 commits into from Sep 27, 2018

Conversation

Projects
None yet
3 participants
@ericronne
Contributor

ericronne commented Sep 25, 2018

  • Brought more explorer elements into line with the new style
  • Improved the grid structure
  • Redesigned the price-summary block to look less like a button bar (since it isn't interactive)
  • Repositioned proposed price to a more logical place (adjacent to the price summary block), also serving to save vertical space on the page
  • Rephrased and restyles the search-summary description, for a stronger visual hierarchy and a quicker scan
  • Shifted the GSA and 18F footer logos up, aligning them with the text subheads
  • Visually fused the graph and table "cards," which saves space and reduces clutter
  • Moved "Restore rows" link so it doesn't hit the edge of the card
  • Saved over 200 pixels overall, vertically
  • Restyled "tooltipster"

screen shot 2018-09-26 at 11 13 45 am

ericronne and others added some commits Sep 25, 2018

Removes outlines from price block
So they look less button-y. Because they aren't buttons.
Shifts footnote *back* cuz better safe than sorry
Felt like too big of a shift to do, given lack of time to test.
Globally reduces right margin on buttons
From 2em down to 1em. 2 is 2 much.
Polishes highlights block and proposed
Likely not ideal method. #helpwanted

@ericronne ericronne changed the base branch from develop to 2151-query-description-rearranging Sep 26, 2018

@hbillings hbillings changed the title from [WIP] Er final fixes to Update title and description of graph to match mocks Sep 26, 2018

ericronne and others added some commits Sep 26, 2018

@hbillings hbillings changed the base branch from 2151-query-description-rearranging to develop Sep 26, 2018

@hbillings hbillings changed the title from Update title and description of graph to match mocks to Update data explorer visuals and grid Sep 26, 2018

ericronne and others added some commits Sep 26, 2018

@ericronne ericronne requested a review from hbillings Sep 26, 2018

@ericronne ericronne requested review from tadhg-ohiggins and tram Sep 26, 2018

@@ -13,7 +13,12 @@ body {
// temp styles to mimic .card without indenting the table
.graph-block {
margin-right: 0;
margin-left: $space-8x;
margin-left: 84px; // Hacky number to approximate card margin value

This comment has been minimized.

@hbillings

hbillings Sep 27, 2018

Member

Wait, why? The card margins should be $space-8x (which works out to 80px). If that's not what you're seeing, something else has padding on it.

This comment has been minimized.

@ericronne

ericronne Sep 27, 2018

Contributor

Alignments were off when I applied that variable.

This comment has been minimized.

@hbillings

hbillings Sep 27, 2018

Member

Right, but it probably wasn't because of that variable, because it's used everywhere else. There's likely something it contains that has a little bit too much right padding or margin. Whatevs, merged it anyway because we're out of time.

This comment has been minimized.

@ericronne

ericronne Sep 27, 2018

Contributor

Yep, this was something i'd hoped to pair on.
Onward... 🇺🇸

@hbillings hbillings merged commit e94dfed into develop Sep 27, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
security/snyk - package.json (CALC) No manifest changes detected
security/snyk - requirements.txt (CALC) No manifest changes detected

@hbillings hbillings deleted the er-final-fixes branch Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment