New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ethnio screener #224

Merged
merged 3 commits into from Jul 14, 2015

Conversation

Projects
None yet
2 participants
@brethauer

brethauer commented Jul 13, 2015

No description provided.

Nick Brethauer added some commits Jul 13, 2015

Nick Brethauer
Nick Brethauer
fix
@@ -138,6 +138,7 @@ <h2 class="description-secondary">CALC lets you conduct market research on profe
}
</script>
<![endif]>
<!-- Ethnio Activation Code -->
<script type="text/javascript" language="javascript" src="//ethn.io/88263.js" async="true" charset="utf-8"></script>

This comment has been minimized.

@theresaanna

theresaanna Jul 13, 2015

Contributor

Protocol relative URLs (the lack of an http: or https: at the beginning of the URL) have become an anti-pattern. Paul Irish nicely summarizes at the top of the article here: http://www.paulirish.com/2010/the-protocol-relative-url/, which mentions the work of our very own @konklone, I should point out.

I'll check out this branch, change the URL and test.

Nick Brethauer

theresaanna added a commit that referenced this pull request Jul 14, 2015

Merge pull request #224 from 18F/ethnio
Add ethnio screener

@theresaanna theresaanna merged commit 1f5090c into master Jul 14, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@theresaanna theresaanna deleted the ethnio branch Jul 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment