New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new service instance doesn't seem to work #672

Closed
brittag opened this Issue Oct 13, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@brittag
Member

brittag commented Oct 13, 2016

Using the current Dashboard (https://dashboard.cloud.gov/), if I go to my britta.gustafson space in my sandbox org and try to create a free service instance (such as shared-psql), it doesn't seem to work for me.

Example steps: I go to the Marketplace for my org, click create service instance in the services list, fill out the form at the bottom of the page, click create service instance, and nothing seems to happen. (I don't get feedback about whether it worked.) If I go check my space's list of service instances, I don't see a new instance there.

Related issue about adding feedback when people click create service instance: #457

@msecret

This comment has been minimized.

Contributor

msecret commented Nov 16, 2016

This is due to the <Action> component re-using the type property that's passed to it for styling purposes. Before the type property was used directly like the type attribute in HTML, so the action on the create service instance form would be type="submit". Now that it's not a submit type anymore, the click handler on the button doesn't function properly.

Solution:
The best solution is to change the <Action> component to not re-use the type property for styling, but use it as the traditional type attribute on the button element. Additionally, all react components should probably not re-use actually html attribute names for properties, but that's something I'd like to solve later.

@msecret msecret self-assigned this Nov 16, 2016

@msecret

This comment has been minimized.

Contributor

msecret commented Nov 16, 2016

Action
+ colorStyle: one of 'cautious', 'warning', 'primary', 'secondary'... 
+ styleType: one of 'outline', 'outline-inverse', 'link'.
+ type: any string (or should we limit to known possible values in HTML as of now?)
+ style: any object
@msecret

This comment has been minimized.

Contributor

msecret commented Nov 16, 2016

Another option is to simplify the interface for less options and hopefully more consistency. There would be one purpose field that would control the button styles itself:

Action
+ purpose: one of 'cautious-complete', 'cautious-try', 'warning-complete', 'safe-edit' ...
+ type: any string (or should we limit to known possible values in HTML as of now?)
+ style: any object
@msecret

This comment has been minimized.

Contributor

msecret commented Nov 16, 2016

@thisisdano @vz3 it might be helpful to get your thoughts on how we should configure/style/name our buttons

@suprenant

This comment has been minimized.

Member

suprenant commented Nov 17, 2016

@thisisdano to review here and follow up.

@brittag

This comment has been minimized.

Member

brittag commented Dec 1, 2016

This works now, thanks everyone! It's a bit confusing since it doesn't consistently give feedback (the form seems to either disappear after service creation, or to stay there after service creation), but the service is created! The feedback issue is filed separately at #457.

@brittag brittag closed this Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment