Skip to content
This repository has been archived by the owner on Dec 23, 2019. It is now read-only.

Implement initial sitemap and draft content for usability testing #35

Merged
merged 27 commits into from
Aug 22, 2018

Conversation

lauraGgit
Copy link

@lauraGgit lauraGgit commented Aug 21, 2018

Summary

https://federalist-proxy.app.cloud.gov/preview/18f/cic-site/implement-sitemap-content/

Impacted areas of the application

List general components of the application that this PR will affect:

  • All the places!

Screenshots

Before
image
After
image

@lauraGgit lauraGgit changed the title Implement sitemap content WIP: Implement sitemap content Aug 21, 2018
@lauraGgit lauraGgit changed the title WIP: Implement sitemap content Implement initial sitemap and draft content for usability testing Aug 22, 2018
@jdamis4XD
Copy link
Contributor

Global Nav looks good.

@jdamis4XD
Copy link
Contributor

jdamis4XD commented Aug 22, 2018

Global nav looks good. Thanks for removing the sub nav from the Acquisition and Implementation overview pages. I want to get users reactions on not having it from those top level pages to determine what we standardize.

Content comments:

  1. The 3 container cards at the bottom of the Acq & Implementation pages don't consistently match the landing pages nor page headers, so a little disorienting and we will need address later.

  2. Next iteration, recommend making the Overview data the top nav category and kill the Overview sub nav category and link.

Copy link
Contributor

@jenniferthibault jenniferthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small markup catch inline (which doesn't look like it's breaking anything, but just in case).

If there's time for a quick styling fix, I think it would be helpful to set the visited state to white on the .usa-nav-submenu class so that the nav items don't appear different from one another — it's not a helpful visual cue in menus like it is for regular text links.

screen shot 2018-08-22 at 8 41 58 am

_config.yml Outdated
@@ -2,11 +2,11 @@
title: Cloud Information Center
description: A site for you to learn about cloud!
baseurl: "" # the subpath of your site, e.g. /blog/
url: "https://federalist-modern-team-template.18f.gov" # the base hostname & protocol for your site
logo: /assets/img/logo-main.gif
url: "https://federalist-proxy.app.cloud.gov/preview/18f/cic-site/implement-sitemap-content/" # the base hostname & protocol for your site
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally familiar with all parts of config, but it seems surprising we'd use the specific branch name here instead of ending say, after /cic-site/. I'd love to understand more about what this does (offline is fine!)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i think is left over from when i was trying to debug the urls, will update

<div class="usa-width-whole hero-content">
<h1>{{ page.hero-text }}</h1>
<a class="usa-button" href="{{ page.hero-button-link | prepend: site.baseurl }}">{{ page.hero-button-text }}</a>
<div class=="usa-width-one-third" style="float: left;margin-right: 2em;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an extra = in here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this explains why the css class wasn't picking up and why I to put in inline (and now can remove!) Great catch!

@lauraGgit
Copy link
Author

@jenniferthibault thanks for the comments! they should be all pushed now!

@jdamis4XD
Copy link
Contributor

jdamis4XD commented Aug 22, 2018

For the Find Cloud Business Solutions > Business and operations sub-category we need to add the following child items in order for users to complete task 3 for the study.

  • Business management
  • Customer relationship management
  • Email
  • Human resources
  • Public and media relations
  • Telecommunications

@jenniferthibault
Copy link
Contributor

We're going to hold on making the last nav change requested by @jdamis4XD — please hold off on making changes to this PR while testing happens on this branch.

@lauraGgit lauraGgit merged commit 4c09584 into dev Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants