Skip to content
This repository has been archived by the owner on Dec 23, 2020. It is now read-only.

"Submit Feedback" component is caching information improperly #267

Closed
cde-feedback-bot opened this issue Aug 1, 2017 · 1 comment
Closed

"Submit Feedback" component is caching information improperly #267

cde-feedback-bot opened this issue Aug 1, 2017 · 1 comment
Assignees
@jeremiak
Labels
type: bug

Comments

@cde-feedback-bot
Copy link

What brought you to the site and how can we improve your experience here?

"Submit Feedback" component is caching information improperly. Once a User submits feedback it does not clear the feedback components contents.

  1. User enters feedback into text areas. 2. User clicks Submit. 3. Success Message is displayed. 4. User closes the feedback component. 5. Opens the feedback component and the contents of their first message is displayed.

General feedback about the site?

Using this data for something cool? Tell us about it!
@jeremiak
Copy link
Contributor

jeremiak commented Aug 2, 2017

@jpwentz and I are going to pair on this tomorrow

@jeremiak jeremiak mentioned this issue Aug 2, 2017
Merged
@jeremiak jeremiak self-assigned this Aug 2, 2017
@LarryBafundo LarryBafundo changed the title User feedback "Submit Feedback" component is caching information improperly Aug 2, 2017
jeremiak pushed a commit to fbi-cde/crime-data-frontend that referenced this issue Aug 2, 2017
Prevent user from submitting empty feedback
0101f80 
Also, clear the component's state after a successful submission so the
UI is empty.

Closes 18F/crime-data-explorer#267
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremiak jeremiak

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremiak @LarryBafundo @cde-feedback-bot