Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Commit

Permalink
Merge 9ad7d5b into f8b2f3d
Browse files Browse the repository at this point in the history
  • Loading branch information
Jacob Harris committed Sep 21, 2016
2 parents f8b2f3d + 9ad7d5b commit 2bf8751
Show file tree
Hide file tree
Showing 36 changed files with 131 additions and 127 deletions.
10 changes: 7 additions & 3 deletions app/models/admin_auction_status_presenter_factory.rb
Expand Up @@ -56,15 +56,19 @@ def other_purchase_card_presenter
end

def available?
AuctionStatus.new(auction).available?
bidding_status.available?
end

def future?
AuctionStatus.new(auction).future?
bidding_status.future?
end

def work_in_progress?
AuctionStatus.new(auction).work_in_progress?
bidding_status.work_in_progress?
end

def bidding_status
@_bidding_status ||= BiddingStatus.new(auction)
end

def status
Expand Down
12 changes: 6 additions & 6 deletions app/models/bid_status_presenter_factory.rb
Expand Up @@ -100,23 +100,23 @@ def ineligible?
end

def work_in_progress?
auction_status.work_in_progress?
bidding_status.work_in_progress?
end

def over?
auction_status.over?
bidding_status.over?
end

def available?
auction_status.available?
bidding_status.available?
end

def future?
auction_status.future?
bidding_status.future?
end

def auction_status
AuctionStatus.new(auction)
def bidding_status
BiddingStatus.new(auction)
end

def user_is_winning_bidder?
Expand Down
@@ -1,4 +1,4 @@
class AuctionStatus
class BiddingStatus
def initialize(auction)
@auction = auction
end
Expand Down
29 changes: 29 additions & 0 deletions app/models/bidding_status_presenter_factory.rb
@@ -0,0 +1,29 @@
class BiddingStatusPresenterFactory
attr_reader :auction

def initialize(auction)
@auction = auction
end

def create
Object.const_get("BiddingStatusPresenter::#{status_name}").new(auction)
end

private

def status_name
if bidding_status.expiring?
'Expiring'
elsif bidding_status.over?
'Over'
elsif bidding_status.future?
'Future'
else
'Available'
end
end

def bidding_status
@_bidding_status ||= BiddingStatus.new(auction)
end
end
2 changes: 1 addition & 1 deletion app/models/rules/base_rules.rb
Expand Up @@ -22,7 +22,7 @@ def user_can_bid?(user)
end

def auction_available?
AuctionStatus.new(auction).available?
BiddingStatus.new(auction).available?
end

def user_is_eligible_to_bid?(user)
Expand Down
29 changes: 0 additions & 29 deletions app/models/status_presenter_factory.rb

This file was deleted.

@@ -1,4 +1,4 @@
class StatusPresenter::Available < StatusPresenter::Base
class BiddingStatusPresenter::Available < BiddingStatusPresenter::Base
def start_label
"Bid start time"
end
Expand Down
@@ -1,4 +1,4 @@
class StatusPresenter::Base
class BiddingStatusPresenter::Base
attr_reader :auction

def initialize(auction)
Expand Down
@@ -1,4 +1,4 @@
class StatusPresenter::Expiring < StatusPresenter::Available
class BiddingStatusPresenter::Expiring < BiddingStatusPresenter::Available
def label_class
'auction-label-expiring'
end
Expand Down
@@ -1,4 +1,4 @@
class StatusPresenter::Future < StatusPresenter::Base
class BiddingStatusPresenter::Future < BiddingStatusPresenter::Base
def start_label
"Bid start time"
end
Expand Down
@@ -1,4 +1,4 @@
class StatusPresenter::Over < StatusPresenter::Base
class BiddingStatusPresenter::Over < BiddingStatusPresenter::Base
def start_label
"Auction started at"
end
Expand Down
8 changes: 4 additions & 4 deletions app/serializers/auction_serializer.rb
Expand Up @@ -55,15 +55,15 @@ def winning_bid
private

def veiled_bids
if object.type == 'sealed_bid' && auction_status.available?
if object.type == 'sealed_bid' && bidding_status.available?
object.bids.where(bidder: scope)
else
object.bids
end
end

def find_winning_bid
if auction_status.available?
if bidding_status.available?
NullBid.new
else
WinningBid.new(object).find
Expand All @@ -74,7 +74,7 @@ def find_customer
object.customer || NullCustomer.new
end

def auction_status
@_auction_status ||= AuctionStatus.new(object)
def bidding_status
@_bidding_status ||= BiddingStatus.new(object)
end
end
2 changes: 1 addition & 1 deletion app/serializers/bid_serializer.rb
Expand Up @@ -45,6 +45,6 @@ def veiled_bidder
end

def auction_available?
AuctionStatus.new(object.auction).available?
BiddingStatus.new(object.auction).available?
end
end
2 changes: 1 addition & 1 deletion app/services/create_auction_ended_job.rb
Expand Up @@ -23,6 +23,6 @@ def job
end

def auction_not_over?
!AuctionStatus.new(auction).over?
!BiddingStatus.new(auction).over?
end
end
12 changes: 6 additions & 6 deletions app/view_models/admin/auction_show_view_model.rb
Expand Up @@ -7,7 +7,7 @@ def initialize(auction:, current_user:)
end

def csv_report_partial
if auction_status.over?
if bidding_status.over?
'admin/auctions/csv_report'
else
'components/null'
Expand All @@ -26,8 +26,8 @@ def admin_auction_status_presenter
AdminAuctionStatusPresenterFactory.new(auction: auction).create
end

def status_presenter
@_status_presenter ||= StatusPresenterFactory.new(auction).create
def bidding_status_presenter
@_status_presenter ||= BiddingStatusPresenterFactory.new(auction).create
end

def admin_data
Expand Down Expand Up @@ -60,7 +60,7 @@ def title
end

def relative_time
status_presenter.relative_time
bidding_status_presenter.relative_time
end

def veiled_bids
Expand Down Expand Up @@ -108,8 +108,8 @@ def c2_fields
end
end

def auction_status
AuctionStatus.new(auction)
def bidding_status
BiddingStatus.new(auction)
end

def customer
Expand Down
2 changes: 1 addition & 1 deletion app/view_models/admin/bid_list_item.rb
Expand Up @@ -37,7 +37,7 @@ def amount_to_currency
end

def auction_available?
AuctionStatus.new(bid.auction).available?
BiddingStatus.new(bid.auction).available?
end

def bidder_not_user?
Expand Down
2 changes: 1 addition & 1 deletion app/view_models/admin/edit_auction_view_model.rb
Expand Up @@ -86,7 +86,7 @@ def default_date_time
end

def closed?
AuctionStatus.new(auction).over?
BiddingStatus.new(auction).over?
end

def publishable?
Expand Down
6 changes: 3 additions & 3 deletions app/view_models/admin/user_auction_view_model.rb
Expand Up @@ -17,8 +17,8 @@ def id
auction.id
end

def status
StatusPresenterFactory.new(auction).create.label
def bidding_status
BiddingStatusPresenterFactory.new(auction).create.label
end

def skills
Expand Down Expand Up @@ -56,7 +56,7 @@ def user_won?
end

def auction_over?
AuctionStatus.new(auction).over?
BiddingStatus.new(auction).over?
end

def auction_accepted?
Expand Down
14 changes: 7 additions & 7 deletions app/view_models/auction_list_item.rb
Expand Up @@ -64,7 +64,7 @@ def winning_bid_partial
end

def relative_time
status_presenter.relative_time
bidding_status_presenter.relative_time
end

def winning_bid_amount_as_currency
Expand All @@ -75,8 +75,8 @@ def winning_bid_amount_as_currency
end
end

def status_presenter
@_status_presenter ||= StatusPresenterFactory.new(auction).create
def bidding_status_presenter
@_status_presenter ||= BiddingStatusPresenterFactory.new(auction).create
end

private
Expand All @@ -86,14 +86,14 @@ def for_small_business?
end

def available?
auction_status.available?
bidding_status.available?
end

def over?
auction_status.over?
bidding_status.over?
end

def auction_status
AuctionStatus.new(auction)
def bidding_status
BiddingStatus.new(auction)
end
end
24 changes: 12 additions & 12 deletions app/view_models/auction_show_view_model.rb
Expand Up @@ -33,8 +33,8 @@ def skills

def auction_data
{
status_presenter.start_label => formatted_date(auction.started_at),
status_presenter.deadline_label => formatted_ended_at,
bidding_status_presenter.start_label => formatted_date(auction.started_at),
bidding_status_presenter.deadline_label => formatted_ended_at,
'Delivery deadline' => formatted_date(auction.delivery_due_at),
'Eligible vendors' => eligibility_label,
'Customer' => customer.agency_name
Expand All @@ -53,8 +53,8 @@ def capitalized_type
auction.type.dasherize.capitalize
end

def status_presenter
@_status_presenter ||= StatusPresenterFactory.new(auction).create
def bidding_status_presenter
@_status_presenter ||= BiddingStatusPresenterFactory.new(auction).create
end

def bid_status_presenter
Expand Down Expand Up @@ -105,15 +105,15 @@ def formatted_accepted_at
end

def tag_data_value_status
status_presenter.tag_data_value_status
bidding_status_presenter.tag_data_value_status
end

def tag_data_label_2
status_presenter.tag_data_label_2
bidding_status_presenter.tag_data_label_2
end

def tag_data_value_2
status_presenter.tag_data_value_2
bidding_status_presenter.tag_data_value_2
end

def highlighted_bid_amount_as_currency
Expand All @@ -125,7 +125,7 @@ def max_allowed_bid_as_currency
end

def relative_time
status_presenter.relative_time
bidding_status_presenter.relative_time
end

def sealed_bids_partial
Expand Down Expand Up @@ -164,15 +164,15 @@ def user_bids
end

def over?
auction_status.over?
bidding_status.over?
end

def available?
auction_status.available?
bidding_status.available?
end

def auction_status
AuctionStatus.new(auction)
def bidding_status
@_bidding_status ||= BiddingStatus.new(auction)
end

def rules
Expand Down
2 changes: 1 addition & 1 deletion app/view_models/bid_list_item.rb
Expand Up @@ -41,7 +41,7 @@ def amount_to_currency
end

def auction_available?
AuctionStatus.new(bid.auction).available?
BiddingStatus.new(bid.auction).available?
end

def bidder_not_user?
Expand Down

0 comments on commit 2bf8751

Please sign in to comment.