Adjust Spacing on Auction Details Page - #237
Conversation
Reduce vertical spacing in description on auction details page. Fixes 18F#216.
|
LGTM! 🎉 Thanks @cwarden! |
|
Great, @vzvenyach. The requirements on this one were light. Let me know if you have other markdown you want me to test. |
Adjust Spacing on Auction Details Page
|
Saw a tweet. 👍 for the quick turn around. If you're interested, here is a slightly refactored of the pull request. h1, h2, h3, h4, h5, h6 {
line-height: 1.1em;
margin-top: 0.2em;
margin-bottom: 0.1em;
}
h1 {
margin-bottom: 0.5em;
}
p, li {
line-height: 1.3em;
}
ul {
margin-bottom: 0.5em;
} |
There was a problem hiding this comment.
@vzvenyach @cwarden why do we need all this added code? All that's required is removing:
.github-issue {
white-space: pre-line;
}
There was a problem hiding this comment.
I found when just removing white-space: pre-line, the vertical spacing was still a bit larger than the 30px max desired.
There was a problem hiding this comment.
The requirement was that it was "significantly reduced." The 30px was stated as "e.g." which means for example, not the requirement. The requirement was to remove the erroneous vertical spacing which was created by white-space: pre-line;. The Draft U.S. Web Design Standards defines the vertical white space and was created for optimal legibility.
|
@maya, your comments suggest some good questions about what tasks are best suited for micro-purchasing, and what level of detail in the requirements is optimal. I've written up some thoughts on my blog. |
|
@cwarden Thanks! Looking forward to reading it! |
5 participants
Reduce vertical spacing in description on auction details page.
Fixes #216.
How does this look?