Adjust Spacing on Auction Details Page #237

Merged
merged 1 commit into from Jan 13, 2016

Projects

None yet

5 participants

@cwarden
Contributor
cwarden commented Jan 13, 2016

Reduce vertical spacing in description on auction details page.

Fixes #216.

How does this look?

2016-01-13-114251_936x1245_scrot

@cwarden cwarden Adjust Spacing on Auction Details Page
Reduce vertical spacing in description on auction details page.

Fixes #216.
9e0f896
@vzvenyach
Member

LGTM! 🎉 Thanks @cwarden!

@cwarden
Contributor
cwarden commented Jan 13, 2016

Great, @vzvenyach. The requirements on this one were light. Let me know if you have other markdown you want me to test.

@adelevie adelevie merged commit 0a1b54f into 18F:develop Jan 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dotmike
dotmike commented Jan 13, 2016

Saw a tweet. 👍 for the quick turn around. If you're interested, here is a slightly refactored of the pull request.

h1, h2, h3, h4, h5, h6 {
  line-height: 1.1em;
  margin-top: 0.2em;
  margin-bottom: 0.1em;
}
h1 {
    margin-bottom: 0.5em;
}
p, li {
  line-height: 1.3em;
}
ul {
  margin-bottom: 0.5em;
}
@maya maya commented on the diff Jan 14, 2016
app/assets/stylesheets/main.scss
+ margin-bottom: 0.5em;
+ }
+
+ h2, h3, h4, h5, h6 {
+ line-height: 1.1em;
+ margin-top: 0.2em;
+ margin-bottom: 0.1em;
+ }
+
+ p, li {
+ line-height: 1.3em;
+ }
+
+ ul {
+ margin-bottom: 0.5em;
+ }
}
@maya
maya Jan 14, 2016 Member

@vzvenyach @cwarden why do we need all this added code? All that's required is removing:

.github-issue {
   white-space: pre-line;
}
@cwarden
cwarden Jan 14, 2016 Contributor

I found when just removing white-space: pre-line, the vertical spacing was still a bit larger than the 30px max desired.

2016-01-14-074916_1029x1313_scrot

@maya
maya Jan 14, 2016 Member

The requirement was that it was "significantly reduced." The 30px was stated as "e.g." which means for example, not the requirement. The requirement was to remove the erroneous vertical spacing which was created by white-space: pre-line;. The Draft U.S. Web Design Standards defines the vertical white space and was created for optimal legibility.

@maya maya referenced this pull request Jan 14, 2016
Merged

Deploy 1/14/16 #1 #238

@cwarden
Contributor
cwarden commented Jan 18, 2016

@maya, your comments suggest some good questions about what tasks are best suited for micro-purchasing, and what level of detail in the requirements is optimal. I've written up some thoughts on my blog.

@vzvenyach
Member

@cwarden Thanks! Looking forward to reading it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment