New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Spacing on Auction Details Page #237

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
5 participants
@cwarden
Contributor

cwarden commented Jan 13, 2016

Reduce vertical spacing in description on auction details page.

Fixes #216.

How does this look?

2016-01-13-114251_936x1245_scrot

Adjust Spacing on Auction Details Page
Reduce vertical spacing in description on auction details page.

Fixes #216.
@vzvenyach

This comment has been minimized.

Show comment
Hide comment
@vzvenyach

vzvenyach Jan 13, 2016

Member

LGTM! 🎉 Thanks @cwarden!

Member

vzvenyach commented Jan 13, 2016

LGTM! 🎉 Thanks @cwarden!

@cwarden

This comment has been minimized.

Show comment
Hide comment
@cwarden

cwarden Jan 13, 2016

Contributor

Great, @vzvenyach. The requirements on this one were light. Let me know if you have other markdown you want me to test.

Contributor

cwarden commented Jan 13, 2016

Great, @vzvenyach. The requirements on this one were light. Let me know if you have other markdown you want me to test.

adelevie added a commit that referenced this pull request Jan 13, 2016

@adelevie adelevie merged commit 0a1b54f into 18F:develop Jan 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dotmike

This comment has been minimized.

Show comment
Hide comment
@dotmike

dotmike Jan 13, 2016

Saw a tweet. 👍 for the quick turn around. If you're interested, here is a slightly refactored of the pull request.

h1, h2, h3, h4, h5, h6 {
  line-height: 1.1em;
  margin-top: 0.2em;
  margin-bottom: 0.1em;
}
h1 {
    margin-bottom: 0.5em;
}
p, li {
  line-height: 1.3em;
}
ul {
  margin-bottom: 0.5em;
}

dotmike commented Jan 13, 2016

Saw a tweet. 👍 for the quick turn around. If you're interested, here is a slightly refactored of the pull request.

h1, h2, h3, h4, h5, h6 {
  line-height: 1.1em;
  margin-top: 0.2em;
  margin-bottom: 0.1em;
}
h1 {
    margin-bottom: 0.5em;
}
p, li {
  line-height: 1.3em;
}
ul {
  margin-bottom: 0.5em;
}
ul {
margin-bottom: 0.5em;
}
}

This comment has been minimized.

@maya

maya Jan 14, 2016

Member

@vzvenyach @cwarden why do we need all this added code? All that's required is removing:

.github-issue {
   white-space: pre-line;
}
@maya

maya Jan 14, 2016

Member

@vzvenyach @cwarden why do we need all this added code? All that's required is removing:

.github-issue {
   white-space: pre-line;
}

This comment has been minimized.

@cwarden

cwarden Jan 14, 2016

Contributor

I found when just removing white-space: pre-line, the vertical spacing was still a bit larger than the 30px max desired.

2016-01-14-074916_1029x1313_scrot

@cwarden

cwarden Jan 14, 2016

Contributor

I found when just removing white-space: pre-line, the vertical spacing was still a bit larger than the 30px max desired.

2016-01-14-074916_1029x1313_scrot

This comment has been minimized.

@maya

maya Jan 14, 2016

Member

The requirement was that it was "significantly reduced." The 30px was stated as "e.g." which means for example, not the requirement. The requirement was to remove the erroneous vertical spacing which was created by white-space: pre-line;. The Draft U.S. Web Design Standards defines the vertical white space and was created for optimal legibility.

@maya

maya Jan 14, 2016

Member

The requirement was that it was "significantly reduced." The 30px was stated as "e.g." which means for example, not the requirement. The requirement was to remove the erroneous vertical spacing which was created by white-space: pre-line;. The Draft U.S. Web Design Standards defines the vertical white space and was created for optimal legibility.

@maya maya referenced this pull request Jan 14, 2016

Merged

Deploy 1/14/16 #1 #238

@cwarden

This comment has been minimized.

Show comment
Hide comment
@cwarden

cwarden Jan 18, 2016

Contributor

@maya, your comments suggest some good questions about what tasks are best suited for micro-purchasing, and what level of detail in the requirements is optimal. I've written up some thoughts on my blog.

Contributor

cwarden commented Jan 18, 2016

@maya, your comments suggest some good questions about what tasks are best suited for micro-purchasing, and what level of detail in the requirements is optimal. I've written up some thoughts on my blog.

@vzvenyach

This comment has been minimized.

Show comment
Hide comment
@vzvenyach

vzvenyach Jan 18, 2016

Member

@cwarden Thanks! Looking forward to reading it!

Member

vzvenyach commented Jan 18, 2016

@cwarden Thanks! Looking forward to reading it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment