Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build error: #319 not compatible with graphql-js v14.2.0 #320

Closed
maplesteve opened this issue Apr 23, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@maplesteve
Copy link

commented Apr 23, 2019

Describe the bug
#319 makes use of the (private) library under graphql/jsutils by importing MaybePromise.
This has been renamed in version 14.2.0 (in #1798) to PromiseOrValue. Building a project which uses graphql >= 14.2.0 now breaks.

To Reproduce
Install graphql-js@14.2.0 and build.

Expected behavior
...builds without failure

They state, that one shouldn't rely on things under jsutils.

@19majkel94

This comment has been minimized.

Copy link
Owner

commented Apr 24, 2019

That's why peer dependency was a bad idea 😞

It's hard to prevent that kind of regression with loose range of supported versions. I would have to create a matrix in Travis to test against all newer versions 😕

I will fix it ASAP and release 0.17.3 🔥

@19majkel94

This comment has been minimized.

Copy link
Owner

commented Apr 24, 2019

Solved by 4677f1a 🔒

@codeninja0x01

This comment has been minimized.

Copy link

commented Apr 24, 2019

I have this build error but thanks to @19majkel94 its solved. just updated to 0.17.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.