Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options for array with nullable element #119 #211

Merged
merged 3 commits into from Dec 22, 2018

Conversation

Projects
2 participants
@kenpusney
Copy link
Contributor

commented Dec 6, 2018

This is to add new options for nullable to resolve issue #119

@codecov

This comment has been minimized.

Copy link

commented Dec 6, 2018

Codecov Report

Merging #211 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   95.39%   95.48%   +0.08%     
==========================================
  Files          60       62       +2     
  Lines         978      996      +18     
  Branches      169      175       +6     
==========================================
+ Hits          933      951      +18     
  Misses         44       44              
  Partials        1        1
Impacted Files Coverage Δ
src/errors/ConflictingDefaultWithNullableError.ts 100% <100%> (ø)
src/helpers/types.ts 96% <100%> (+1%) ⬆️
src/errors/index.ts 100% <100%> (ø) ⬆️
src/errors/WrongNullableListOptionError.ts 100% <100%> (ø)
src/schema/schema-generator.ts 97.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c740d1f...470cb58. Read the comment docs.

@19majkel94
Copy link
Owner

left a comment

Thank you very much for your contribution! ❤️
Please tweak some things pointed in review and also add a proper info about this options in docs 😉

Show resolved Hide resolved src/decorators/types.ts Outdated
Show resolved Hide resolved src/helpers/types.ts Outdated
Show resolved Hide resolved tests/functional/resolvers.ts
@19majkel94

This comment has been minimized.

Copy link
Owner

commented Dec 14, 2018

@kenpusney
Are you going to finish this up or should I checkout your branch and add some changes there?
We have to also add a proper info about this options in docs 📝

@kenpusney

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

@19majkel94
sorry get lost in massive work, possibly have no enough time to finish this. Please do help if you can, thanks.

@19majkel94 19majkel94 added this to In review in Board Dec 22, 2018

@19majkel94 19majkel94 merged commit 1426446 into 19majkel94:master Dec 22, 2018

3 checks passed

codecov/patch 100% of diff hit (target 95.39%)
Details
codecov/project 95.48% (+0.08%) compared to c740d1f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Board automation moved this from In review to Done Dec 22, 2018

@19majkel94

This comment has been minimized.

Copy link
Owner

commented Dec 22, 2018

@kenpusney
Once again: thank you very much for your contribution! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.