Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for typeDefs and resolvers ecosystem compatibility #233

Merged
merged 5 commits into from Jan 21, 2019

Conversation

Projects
1 participant
@19majkel94
Copy link
Owner

commented Jan 20, 2019

Closes #222 and allows for #135.
For #197 it needs example and a confirmation.

@19majkel94 19majkel94 added this to the 1.0.0 release milestone Jan 20, 2019

@19majkel94 19majkel94 self-assigned this Jan 20, 2019

@19majkel94 19majkel94 added this to In review in Board via automation Jan 20, 2019

@19majkel94 19majkel94 force-pushed the typedefs-resolvers branch from 0cd7193 to 1fdebba Jan 20, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 20, 2019

Codecov Report

Merging #233 into master will decrease coverage by <.01%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   95.49%   95.49%   -0.01%     
==========================================
  Files          62       65       +3     
  Lines         999     1043      +44     
  Branches      177      186       +9     
==========================================
+ Hits          954      996      +42     
- Misses         44       46       +2     
  Partials        1        1
Impacted Files Coverage Δ
src/utils/index.ts 100% <100%> (ø)
src/index.ts 100% <100%> (ø) ⬆️
src/utils/buildTypeDefsAndResolvers.ts 100% <100%> (ø)
src/utils/createResolversMap.ts 94.59% <94.59%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6901da1...1fdebba. Read the comment docs.

@19majkel94 19majkel94 changed the title Add buildTypeDefsAndResolvers utils function Add support for typeDefs and resolvers ecosystem compatibility Jan 20, 2019

@19majkel94 19majkel94 merged commit 63d4858 into master Jan 21, 2019

4 checks passed

codecov/patch 96% of diff hit (target 95.49%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.5% compared to 6901da1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Board automation moved this from In review to Done Jan 21, 2019

@19majkel94 19majkel94 deleted the typedefs-resolvers branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.