Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic types support #255

Merged
merged 4 commits into from Feb 21, 2019

Conversation

Projects
2 participants
@19majkel94
Copy link
Owner

commented Feb 16, 2019

This PR closes #180 馃敀

@19majkel94 19majkel94 added this to the 1.0.0 release milestone Feb 16, 2019

@19majkel94 19majkel94 self-assigned this Feb 16, 2019

@19majkel94 19majkel94 added this to In review in Board via automation Feb 16, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 16, 2019

Codecov Report

Merging #255 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   95.43%   95.56%   +0.12%     
==========================================
  Files          67       67              
  Lines         921      925       +4     
  Branches       69       72       +3     
==========================================
+ Hits          879      884       +5     
+ Misses         40       38       -2     
- Partials        2        3       +1
Impacted Files Coverage 螖
src/decorators/InputType.ts 100% <酶> (酶) 猬嗭笍
src/decorators/ObjectType.ts 100% <酶> (酶) 猬嗭笍
src/decorators/InterfaceType.ts 100% <酶> (酶) 猬嗭笍
src/schema/schema-generator.ts 96.13% <100%> (+0.08%) 猬嗭笍
src/helpers/decorators.ts 92.85% <0%> (+7.14%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 37d499c...1871aae. Read the comment docs.

@19majkel94 19majkel94 force-pushed the generic-types branch 4 times, most recently from 88476ba to e3ca4e9 Feb 16, 2019

@19majkel94 19majkel94 force-pushed the generic-types branch from e3ca4e9 to 1871aae Feb 21, 2019

@19majkel94 19majkel94 marked this pull request as ready for review Feb 21, 2019

@19majkel94 19majkel94 changed the title WIP: Generic types support Generic types support Feb 21, 2019

@19majkel94 19majkel94 merged commit 084ca96 into master Feb 21, 2019

4 checks passed

codecov/patch 100% of diff hit (target 95.43%)
Details
codecov/project 95.56% (+0.12%) compared to 37d499c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Board automation moved this from In review to Done Feb 21, 2019

@19majkel94 19majkel94 deleted the generic-types branch Feb 21, 2019

@frankdugan3

This comment has been minimized.

Copy link

commented Feb 22, 2019

This feature looks awesome! Any chance for a release bump that includes this feature?

@19majkel94

This comment has been minimized.

Copy link
Owner Author

commented Feb 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.