Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types field at package.json, because we do not use default value #276

Merged
merged 2 commits into from Mar 16, 2019

Conversation

Projects
None yet
3 participants
@galkin
Copy link
Contributor

commented Mar 12, 2019

@19majkel94, I migrated to 0.17 and lost typescripts support at WebStorm. This pull should fix the issue.

@codecov

This comment has been minimized.

Copy link

commented Mar 12, 2019

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          67       67           
  Lines         947      947           
  Branches       72       72           
=======================================
  Hits          906      906           
  Misses         38       38           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51278f4...67f938e. Read the comment docs.

@19majkel94
Copy link
Owner

left a comment

LGTM! 💪

@19majkel94

This comment has been minimized.

Copy link
Owner

commented Mar 16, 2019

@galkin
I don't have Webstorm but this change doesn't break VSCode support so we can safely merge it 🎉

@19majkel94 19majkel94 merged commit 572eddd into 19majkel94:master Mar 16, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 51278f4...67f938e
Details
codecov/project 95.67% remains the same compared to 51278f4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ForsakenHarmony

This comment has been minimized.

Copy link

commented Mar 27, 2019

should have been broken in vscode as well 🤔

also can you please release this, it's pretty important for a typescript focused package

@galkin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

@19majkel94, when will you publish new version?

@19majkel94

This comment has been minimized.

Copy link
Owner

commented Mar 29, 2019

@ForsakenHarmony @galkin
It took me a while but type-graphql@0.17.1 has been released! 🎉

@galkin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

@19majkel94, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.