Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for defining `resolveType` for interfaces and unions #319

Merged
merged 2 commits into from Apr 23, 2019

Conversation

Projects
1 participant
@19majkel94
Copy link
Owner

commented Apr 22, 2019

No description provided.

@19majkel94 19majkel94 added this to the 1.0.0 release milestone Apr 22, 2019

@19majkel94 19majkel94 self-assigned this Apr 22, 2019

@19majkel94 19majkel94 added this to In review in Board via automation Apr 22, 2019

@19majkel94 19majkel94 force-pushed the resolve-type-support branch from a90150a to 913196e Apr 22, 2019

@19majkel94 19majkel94 marked this pull request as ready for review Apr 22, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #319 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   94.33%   94.37%   +0.04%     
==========================================
  Files          69       69              
  Lines         971      978       +7     
  Branches       72       74       +2     
==========================================
+ Hits          916      923       +7     
  Misses         52       52              
  Partials        3        3
Impacted Files Coverage Δ
src/decorators/InterfaceType.ts 100% <ø> (ø) ⬆️
src/schema/schema-generator.ts 96.41% <100%> (+0.13%) ⬆️
src/decorators/unions.ts 100% <100%> (ø) ⬆️
src/metadata/metadata-storage.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165ba1e...4476223. Read the comment docs.

@19majkel94 19majkel94 force-pushed the resolve-type-support branch from 913196e to 4476223 Apr 22, 2019

@19majkel94 19majkel94 changed the title Support for defining `resolveType` for interfaces and unions Add support for defining `resolveType` for interfaces and unions Apr 23, 2019

@19majkel94 19majkel94 merged commit 523063e into master Apr 23, 2019

4 checks passed

codecov/patch 100% of diff hit (target 94.33%)
Details
codecov/project 94.37% (+0.04%) compared to 165ba1e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Board automation moved this from In review to Done Apr 23, 2019

@19majkel94 19majkel94 deleted the resolve-type-support branch Apr 23, 2019

19majkel94 added a commit that referenced this pull request Apr 23, 2019

Merge pull request #319 from 19majkel94/resolve-type-support
Add support for defining `resolveType` for interfaces and unions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.