Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom parameter decorators #329

Merged
merged 4 commits into from May 6, 2019

Conversation

Projects
1 participant
@19majkel94
Copy link
Owner

commented May 5, 2019

This PR allows to create a custom param decorators, described in #45.

@19majkel94 19majkel94 added this to the 1.0.0 release milestone May 5, 2019

@19majkel94 19majkel94 self-assigned this May 5, 2019

@19majkel94 19majkel94 added this to In review in Board via automation May 5, 2019

@codecov

This comment has been minimized.

Copy link

commented May 5, 2019

Codecov Report

Merging #329 into master will decrease coverage by 0.02%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   94.48%   94.45%   -0.03%     
==========================================
  Files          69       71       +2     
  Lines         979      992      +13     
  Branches       74       74              
==========================================
+ Hits          925      937      +12     
- Misses         51       52       +1     
  Partials        3        3
Impacted Files Coverage Δ
src/resolvers/helpers.ts 100% <100%> (ø) ⬆️
src/decorators/createMethodDecorator.ts 100% <100%> (ø)
src/decorators/index.ts 100% <100%> (ø) ⬆️
src/decorators/createParamDecorator.ts 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f992d8...c2411c3. Read the comment docs.

@19majkel94 19majkel94 force-pushed the custom-param-decorators branch from 7e260de to c7afda6 May 5, 2019

@19majkel94 19majkel94 force-pushed the custom-param-decorators branch from c7afda6 to c2411c3 May 6, 2019

@19majkel94 19majkel94 merged commit 59ef256 into master May 6, 2019

2 of 4 checks passed

codecov/patch 94.11% of diff hit (target 94.48%)
Details
codecov/project 94.45% (-0.03%) compared to 0f992d8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Board automation moved this from In review to Done May 6, 2019

@19majkel94 19majkel94 deleted the custom-param-decorators branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.