Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable link tag from tab index #213

Merged

Conversation

kamikazebr
Copy link
Member

@kamikazebr kamikazebr commented Apr 8, 2022

image

Keyboard-focusable = disabled

Its affect all a tag, link tag.

@kamikazebr kamikazebr linked an issue Apr 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #213 (bcaf942) into main (95fe6f4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
  Branches         5         5           
=========================================
  Hits            25        25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95fe6f4...bcaf942. Read the comment docs.

@kamikazebr kamikazebr requested a review from Corantin April 8, 2022 04:25
@vercel
Copy link

vercel bot commented Apr 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/quests/mQYTqU7EaFxHBmUwJdDuTEUmHCsq
✅ Preview: https://quests-git-204-tab-navigation-in-a-quest-summarize-dbf88c-1hive.vercel.app

@vercel vercel bot temporarily deployed to Preview April 8, 2022 04:26 Inactive
@kamikazebr kamikazebr self-assigned this Apr 8, 2022
@kamikazebr kamikazebr merged commit 9d6df62 into main Apr 8, 2022
@kamikazebr kamikazebr deleted the 204-tab-navigation-in-a-quest-summarized-is-broken branch April 8, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab navigation in a quest summarized is broken
2 participants