diff --git a/backend/utils/files/file_op.go b/backend/utils/files/file_op.go index b0ff04c9b3e4..7355d1708637 100644 --- a/backend/utils/files/file_op.go +++ b/backend/utils/files/file_op.go @@ -314,6 +314,7 @@ func (f FileOp) DownloadFile(url, dst string) error { if err != nil { return err } + defer resp.Body.Close() out, err := os.Create(dst) if err != nil { @@ -324,8 +325,6 @@ func (f FileOp) DownloadFile(url, dst string) error { if _, err = io.Copy(out, resp.Body); err != nil { return fmt.Errorf("save download file [%s] error, err %s", dst, err.Error()) } - out.Close() - resp.Body.Close() return nil } diff --git a/backend/utils/files/utils.go b/backend/utils/files/utils.go index f44441db9a97..6dfbd4c4e2c5 100644 --- a/backend/utils/files/utils.go +++ b/backend/utils/files/utils.go @@ -3,7 +3,6 @@ package files import ( "bufio" "fmt" - "github.com/spf13/afero" "io" "net/http" "os" @@ -12,6 +11,8 @@ import ( "strconv" "strings" "sync" + + "github.com/spf13/afero" ) func IsSymlink(mode os.FileMode) bool { @@ -144,8 +145,5 @@ func GetParentMode(path string) (os.FileMode, error) { } func IsInvalidChar(name string) bool { - if strings.Contains(name, "&") { - return true - } - return false + return strings.Contains(name, "&") } diff --git a/backend/utils/http/get.go b/backend/utils/http/get.go index 1f8255d6c590..66a9aed1bb45 100644 --- a/backend/utils/http/get.go +++ b/backend/utils/http/get.go @@ -43,7 +43,6 @@ func GetHttpRes(url string) (*http.Response, error) { return nil, buserr.WithMap("ErrHttpReqFailed", map[string]interface{}{"err": err.Error()}, err) } } - defer resp.Body.Close() if resp.StatusCode == 404 { return nil, buserr.New("ErrHttpReqNotFound") } diff --git a/frontend/src/views/website/website/index.vue b/frontend/src/views/website/website/index.vue index 6d284884bbfc..9f04bfadeb48 100644 --- a/frontend/src/views/website/website/index.vue +++ b/frontend/src/views/website/website/index.vue @@ -111,11 +111,12 @@ - - - +