Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: build type-check error

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 28, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 8a1284d into v2 Nov 28, 2025
3 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_build branch November 28, 2025 08:58
const workflow_mode: WorkflowMode = inject('workflowMode') || WorkflowMode.Application
defineProps({
show: {
type: Boolean,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Line 6: You can remove the || WorkflowMode.Application as TypeScript will infer the type of inject('workflowMode').
  • Line 7: Ensure that $v-model.show, $v-model.workflow_mode, and other reactive properties used in templates have valid bindings to ensure Vue's reactivity system works correctly.
  • Line 9: Since you are using defineProps with types, the line should be updated accordingly based on what values your component expects. For example:
defineProps<{
  mode?: WorkflowMode;
  show?: boolean; // Optional property if desired
}>();

This is assuming that mode might also be provided through props.

Overall, focusing on proper TypeScript inference and ensuring correct data binding within the component template would generally suffice for this piece of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants