Stop copying annotations from OnePasswordItem and Deployment to Secret #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason for random annotations to be carried over. This can lead to weird problems like the `kubectl.kubernetes.io/last-applied-configuration` annotation ending up on a Secret.
jillianwilson
approved these changes
Apr 11, 2022
|
Actually, there is a need, lot's of integration is based on annotations, not only labels. So user should be able to define annotations for the secret. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason for random annotations to be carried over from a Deploument or OnePasswordItem to a Secret. This can lead to weird problems like the
kubectl.kubernetes.io/last-applied-configurationannotation ending up on a Secret as reported in #102.The only annotation that needs to be copied is
operator.1password.io/auto-restart, but that already happens explicitly.Fixes #102.