From d116511070c80520135522941ade05a3fb5b1ba2 Mon Sep 17 00:00:00 2001
From: "Marco Antonio J. Costa" <marco.antonio.costa@gmail.com>
Date: Fri, 27 Dec 2024 02:27:52 -0300
Subject: [PATCH] silence narrowing conversions in MSVC

we all know they're there, whenever someone fixes it (lol), this
should be removed
---
 CMakeLists.txt | 4 ++++
 TODO           | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 403a2f558..eaff06529 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -15,6 +15,10 @@ if(ADDRESS_SANITIZER)
 	add_compile_options($<IF:$<OR:$<CONFIG:Debug>,$<CONFIG:RelWithDebInfo>>,-fsanitize=address,>)
 endif()
 
+if(MSVC)
+	add_compile_options("/wd4838")
+endif()
+
 # whether we are using MSBuild as a generator
 set(usingMsBuild $<STREQUAL:${CMAKE_VS_PLATFORM_NAME},Win32>)
 
diff --git a/TODO b/TODO
index 8b1378917..e4bb3a3c7 100644
--- a/TODO
+++ b/TODO
@@ -1 +1,4 @@
+# stuff that needs doing
+# priority (LOW,HIGH) and description
 
+LOW readd the C4838 (https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4838) warning to CMakeLists.txt once they're all fixed in the code