From 4331a0cfb81c8e3eae50848e5ca9dc30e00b9c96 Mon Sep 17 00:00:00 2001
From: "Marco Antonio J. Costa" <marco.antonio.costa@gmail.com>
Date: Sun, 5 Jan 2025 10:43:11 -0300
Subject: [PATCH] make sure CI to assemble release on 'v*' tag push or manually

also put bash script through shellcheck to be more posix compliant
---
 .github/workflows/build.yml          | 31 ++++++++++++++++------------
 .github/workflows/build_language.yml |  2 +-
 2 files changed, 19 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index c25feead0..3f0fc20f5 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -34,25 +34,30 @@ jobs:
         name: Set global variables
         run: |
           set -eux
-          
-          full_release='${{ ( github.repository == '1dot13/source' && github.ref_name == 'master' ) || startsWith(github.ref, 'refs/tags/v') }}'
-          
-          if [[ '${{ inputs.build_all_languages }}' == 'true' || ( '${{ inputs.build_all_languages }}' == '' && "$full_release" == 'true' ) ]]
+
+          all_languages="${{ inputs.build_all_languages }}"
+          assemble_release="${{ inputs.assemble_release }}"
+          repo="${{ github.repository }}"
+          refname="${{ github.ref_name }}"
+          is_tag="${{ startsWith(github.ref, 'refs/tags/v') }}"
+
+          if [ "$assemble_release" = "true" ] || { [ "$repo" = "1dot13/source" ] && [ "$refname" = "master" ] && [ "$is_tag" = "true" ]; }
           then
-            languages_json_array='["Chinese", "German", "English", "French", "Polish", "Italian", "Dutch", "Russian"]';
+            full_release="true"
           else
-            # English + some other language for compilation testing
-            languages_json_array='["German", "English"]'
+            full_release="false"
           fi
-          echo "languages_json_array=$languages_json_array" >> $GITHUB_OUTPUT
-          
-          if [[ '${{ inputs.assemble_release }}' == 'true' || ( '${{ inputs.assemble_release }}' == '' && "$full_release" == 'true' ) ]]
+
+          if [ "$all_languages" = "true" ] || [ "$full_release" = "true" ]
           then
-            assemble_release='true'
+            languages_json_array='["Chinese", "German", "English", "French", "Polish", "Italian", "Dutch", "Russian"]'
           else
-            assemble_release='false'
+            # English + some other language for compilation testing
+            languages_json_array='["German", "English"]'
           fi
-          echo "assemble_release=$assemble_release" >> $GITHUB_OUTPUT
+
+          echo "languages_json_array=$languages_json_array" >> "$GITHUB_OUTPUT"
+          echo "assemble_release=$full_release" >> "$GITHUB_OUTPUT"
 
       - name: Clone repos metadata
         run: |
diff --git a/.github/workflows/build_language.yml b/.github/workflows/build_language.yml
index 0f97c7339..931a6522c 100644
--- a/.github/workflows/build_language.yml
+++ b/.github/workflows/build_language.yml
@@ -11,7 +11,7 @@ on:
       assemble:
         description: 'assemble full package'
         required: true
-        default: true
+        default: false
         type: boolean
       continue-on-error:
         description: 'allows a language to fail, used when building all languages'