From c0aae9e7af8015e93a5dbdd4293fc927b819e90c Mon Sep 17 00:00:00 2001 From: "Marco Antonio J. Costa" Date: Wed, 8 Apr 2026 14:44:49 -0300 Subject: [PATCH] make preprocessor definitions consistent in every single lib SGP did not seem to make any use of compilationFlags or debugFlags when translating from msbuild to cmake, but there could be a thrice removed transitive include I've missed. there's a small probability this fixes some obscure UB or one-definition rule violation that's causing the mystery crashes people have reported --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index fab983a1f..1c467d488 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -163,5 +163,5 @@ foreach(app IN LISTS ApplicationTargets) # for SGP only target_link_libraries(${app}_sgp PRIVATE "ddraw.lib" "${PROJECT_SOURCE_DIR}/fmodvc.lib") target_link_libraries(${app}_sgp PRIVATE libpng) - target_compile_definitions(${app}_sgp PRIVATE NO_ZLIB_COMPRESSION) + target_compile_definitions(${app}_sgp PRIVATE ${compilationFlags} ${debugFlags} NO_ZLIB_COMPRESSION) endforeach()